#17 - Update quality stack - #18
Merged
Merged
Conversation
- rector.php: replace removed SymfonySetList::SYMFONY_64 / PHPUnitSetList::PHPUNIT_100 sets by withComposerBased() - composer.json: declare used Symfony packages and set a PHPUnit range, so Rector targets the lowest supported versions - Apply rector / php-cs-fixer / phpstan run Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17
rector.php: replace the removedSymfonySetList::SYMFONY_64/PHPUnitSetList::PHPUNIT_100sets bywithComposerBased(), drop the duplicatedSymfonySetList::SYMFONY_CODE_QUALITY(already enabled bywithPreparedSets(symfonyCodeQuality: true))composer.json: declare the Symfony packages used by the code and set a PHPUnit range (^10.5lower bound instead of*). As asymfony-bundle, Rector binds version-specific rules to the lowest version of each declared constraint, i.e. Symfony 6.4 / PHPUnit 10.5Checks (PHP 8.5, latest dependencies)
vendor/bin/rector composer-based: declared Symfony packages resolved to 6.4, PHPUnit resolved to 10.5, no PHPUnit >= 11 rule active. Remaining Symfony >= 7 active rules only target packages not used by the bundle code (installed transitively), so they have no effectNo tests executed!)Requirements
Breaking changes
requireentries were already installed transitively)🤖 Generated with Claude Code