Skip to content

#190 - Update quality stack - #191

Merged
njoubert-cleverage merged 1 commit into
mainfrom
190
Sep 24, 2026
Merged

njoubert-cleverage merged 1 commit into
mainfrom
190

Conversation

@njoubert-cleverage

@njoubert-cleverage njoubert-cleverage commented Sep 24, 2026

Copy link
Copy Markdown
Member

Description

Fixes #190

  • rector.php: replace the removed SymfonySetList::SYMFONY_64 / PHPUnitSetList::PHPUNIT_100 sets by withComposerBased(), drop the duplicated SymfonySetList::SYMFONY_CODE_QUALITY (already enabled by withPreparedSets(symfonyCodeQuality: true))
  • composer.json: declare the Symfony packages used by the code and set a PHPUnit range (^10.5 lower bound instead of *). As a symfony-bundle, Rector binds version-specific rules to the lowest version of each declared constraint, i.e. Symfony 6.4 / PHPUnit 10.5
  • Full quality stack run (rector, php-cs-fixer, phpstan), files changed by Rector:
    • src/Model/SubprocessInstance.php
    • src/Task/ColumnAggregatorTask.php
    • src/Task/File/Csv/CsvWriterTask.php
    • src/Transformer/CachedTransformer.php
    • src/Transformer/Xml/XpathEvaluatorTransformer.php

Checks (PHP 8.5, latest dependencies)

  • vendor/bin/rector composer-based: declared Symfony packages resolved to 6.4, PHPUnit resolved to 10.5, no PHPUnit >= 11 rule active. Remaining Symfony >= 7 active rules only target packages not used by the bundle code (installed transitively), so they have no effect
  • rector / php-cs-fixer: clean after this run
  • phpstan: no errors
  • phpunit: OK (70 tests, 88 assertions)

Requirements

  • Documentation updates
    • Reference
    • Cookbooks
    • Changelog
  • Unit tests

Breaking changes

  • None (dev tooling; the added require entries were already installed transitively)

🤖 Generated with Claude Code

- rector.php: replace removed SymfonySetList::SYMFONY_64 / PHPUnitSetList::PHPUNIT_100 sets by withComposerBased()
- composer.json: declare used Symfony packages and set a PHPUnit range, so Rector targets the lowest supported versions
- Apply rector / php-cs-fixer / phpstan run

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@njoubert-cleverage njoubert-cleverage self-assigned this Sep 24, 2026
@njoubert-cleverage
njoubert-cleverage merged commit c7c4896 into main Sep 24, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update quality stack

1 participant