#189 - Fix EventDispatcherTask ignoring the event_name option - #196
Open
Tmalboeuf-CA wants to merge 1 commit into
Open
Tmalboeuf-CA wants to merge 1 commit into
Tmalboeuf-CA wants to merge 1 commit into
Conversation
The event was dispatched without a name, so it was only dispatched under its class name and listeners registered on the configured `event_name` were never called. Regression from a833456 (v4.0). - Dispatch the event under `event_name` again - Make `event_name` optional and nullable, consistently with EventDispatcherInterface::dispatch(): when null (default), the event is dispatched under its class name, as before - Update the reference documentation Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #189.
EventDispatcherTaskdispatched its event without a name, so listeners registered onevent_namewere never called (regression from a833456, v4.0).event_nameagain.event_nameis now optional and nullable, consistent withEventDispatcherInterface::dispatch(object $event, ?string $eventName = null). When it isnull(default), the event is dispatched under its class name, as before.Requirements
Breaking changes
None: configurations without
event_namekeep dispatching under the event class name. Listeners onEventDispatcherTaskEventare still called whenevent_nameis not set.