Conversation
… 0.1.7-rc.2)
dsh 0.1.7-rc.2 retired the generic kind:'plugin' message source — the v4
session format now requires every durable message to carry a producer-owned
source kind (a non-empty string that is not 'plugin'). The opening inject()
framing line used source:{kind:'plugin',plugin:'dsh-taskboard'}, so every
scheduled/manual execution's turn failed with
'format v4 message requires a producer-owned source kind' (logged as
[dsh-taskboard] turn error detail).
Replace it with the plugin's own kind 'dsh-taskboard' (declared in
MessageSourceMap, matching the cordis-host-runner / runtime-context convention
where each producer owns its source kind). The followup() body already used
kind:'user' and is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On dsh 0.1.7-rc.2, every scheduled/manual task execution fails its opening turn:
dsh 0.1.7-rc.2 retired the generic
kind: 'plugin'message source. The v4 session format'ssource()validator now requires every durable message to carry a producer-ownedsource.kind— a non-empty string that is not'plugin'. The openinginject()framing line usedsource: { kind: 'plugin', plugin: 'dsh-taskboard' }, so the v4 format rejects it and the whole turn fails.Fix
src/host/execution.ts— replace the retiredkind: 'plugin'with the plugin's own kind'dsh-taskboard', and declare it inMessageSourceMapso the taskboard owns its attribution (matching thecordis-host-runner/runtime-contextconvention where each producer owns its source kind):The
followup()body already usedkind: 'user'and is unchanged.tests/execution.spec.tsupdated to assert the new kind.Verification (target: dsh 0.1.7-rc.2)
tsdownbuild (host + client) succeeds.vitest: 346/346 tests pass (including the execution specs that exercise the inject framing path).lib/host/execution.jscarrieskind: "dsh-taskboard"(no'plugin').The same class of bug + fix was confirmed in another scheduled-task plugin on 0.1.7-rc.2.