Skip to content

Review: a re-judged open finding can leave a not-met entry unrecorded; placeholder says 'no findings' beside a not-met entry #638

Closed

Description

@kirkmarple-clockgrove

Two follow-ups from the review of #636 (#634):

  1. A not-met entry can go unrecorded after "judge again". review.mjs:1946 reads the open-findings set before the "judge again" step. If that step resolves the old thread with no worker pass, the reviewer's fresh "not met" for that entry has neither a comment nor an open thread, and the body line "its finding is already open" is untrue. It needs a gateway failure in the last stage plus a new reviewer pass, so it is rare. Fix: read the open set after "judge again", or post the comment when the thread it relied on was just resolved.
  2. The placeholder line comment says "no findings" on a review whose body lists a not-met entry, one assigned by decision or one whose finding is already open. It should say the review has no new line findings and point to the body.

Acceptance: one regression test for 1. None for 2, which is text only.

Activity

  1. kirkmarple-clockgrove commented on Nov 19, 2026

    @kirkmarple-clockgrove
    ContributorAuthor

    Blocked by #636: needs it merged first, since both change the open-findings read in review.mjs.

  2. kirkmarple-clockgrove commented on Nov 19, 2026

    @kirkmarple-clockgrove
    ContributorAuthor

    Unblocked: #636 merged at 656f60c; work started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Low impact: minor bug or cleanup; deferred

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions