You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Review: a re-judged open finding can leave a not-met entry unrecorded; placeholder says 'no findings' beside a not-met entry #638
A not-met entry can go unrecorded after "judge again".review.mjs:1946 reads the open-findings set before the "judge again" step. If that step resolves the old thread with no worker pass, the reviewer's fresh "not met" for that entry has neither a comment nor an open thread, and the body line "its finding is already open" is untrue. It needs a gateway failure in the last stage plus a new reviewer pass, so it is rare. Fix: read the open set after "judge again", or post the comment when the thread it relied on was just resolved.
The placeholder line comment says "no findings" on a review whose body lists a not-met entry, one assigned by decision or one whose finding is already open. It should say the review has no new line findings and point to the body.
Acceptance: one regression test for 1. None for 2, which is text only.
Activity
kirkmarple-clockgrove commentedon Nov 19, 2026
Blocked by #636: needs it merged first, since both change the open-findings read in review.mjs.
kirkmarple-clockgrove commentedon Nov 19, 2026
Unblocked: #636 merged at 656f60c; work started.
Review: findings about to be judged again hold back no not-met comment (