Skip to content

Review: a not-met entry whose open finding the check resolves gets its comment; the placeholder points to the body (#638) - #643

Merged
kirkmarple-clockgrove merged 2 commits into
mainfrom
fix/638
Nov 19, 2026
Merged

kirkmarple-clockgrove merged 2 commits into
mainfrom
fix/638

Conversation

@kirkmarple-clockgrove

@kirkmarple-clockgrove kirkmarple-clockgrove commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Closes #638

1. A not-met entry is never left unrecorded after "judge again". Before reviewPost, the review stage reads the answer-rounds record (readAnswerRounds + checkState). It then drops from the open findings every one whose answer the last stage's check got no verdict on (settledOpen, review.mjs). Those findings are judged again after the review goes up and may be resolved then, so their entries get their not-met comment in the main review. This covers every path, including a stage that ends between the post and "judge again" (the third-party waiting exit, a stop, an outage), and needs no later post. The trade-off: when the check leaves such a finding open, its entry has two open threads.

If the record can't be read, no open finding holds an entry back, so every not-met entry gets its comment. An outage still ends the stage, as it does on any read.

2. Placeholder text. When the review body lists an entry not met that has no comment (assigned by a decision, or with its finding open), the placeholder now says "no new line findings; the review body lists the acceptance entries not met." The marker is unchanged.

docs/PLAN.md says both.

Test: one regression test, #638 in plugin/test/exit.test.mjs. reviewPost is given an open finding for entry A, minus the ids about to be judged again (settledOpen), and the review has A's not-met comment. On main it fails because settledOpen does not exist.

Local checks: lint passes; the plugin suite (1133) and the bench suite (43) pass, each with and without GITHUB_GRAPHQL_URL.

🤖 Generated with Claude Code

https://claude.ai/code/session_017VqP6hg8ahWzteM9zqi8pU

…s comment; the placeholder points to the body (#638)

reviewPost leaves out the not-met comment for an entry whose finding is
already open, and now returns each such comment in `relied` with the ids of
those findings. The "judge again" step runs after the review is posted; when
the finding check resolves every finding an entry relied on, the review stage
posts that entry's not-met comment in a review of its own (marked, so it is
Pendulum's finding) before the answer list is read, so the answer pass takes
it. No not-met entry is left with neither a comment nor an open thread.

The placeholder line comment no longer says "no findings" when the review body
lists an entry not met (assigned by a decision, or with its finding open): it
says there are no new line findings and points to the body. Its marker is
unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017VqP6hg8ahWzteM9zqi8pU
#638)

Review of #643: the `relied` list lived only in the stage's memory, so a stage
that ended between the review post and "judge again" (thirdPartyGate's
`waiting` exit, a stop, an outage, a throw from the extra post) lost it, and a
not-met entry was again left with neither a comment nor an open thread.

Before reviewPost, the stage now reads the answer-rounds record and drops from
the open findings every one whose answer the last stage's check got no verdict
on (checkState `unjudged`): those are judged again after the review goes up and
may be resolved then. Their entries get their not-met comment in the main
review; when the check leaves the finding open, the entry has two open threads.
With the record unread (not an outage), no open finding holds an entry back.
The `relied` list, reliedResolved and the extra review are gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017VqP6hg8ahWzteM9zqi8pU
@kirkmarple-clockgrove
kirkmarple-clockgrove added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 11fc31f Nov 19, 2026
10 checks passed
@kirkmarple-clockgrove
kirkmarple-clockgrove deleted the fix/638 branch November 19, 2026 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review: a re-judged open finding can leave a not-met entry unrecorded; placeholder says 'no findings' beside a not-met entry

1 participant