Skip to content

Progress card: CI waits in time order and timed from their pass's start; a red-only review pass is a fix; the timeline chart mirrors the table - #645

Queued
kirkmarple-clockgrove wants to merge 5 commits into
mainfrom
fix/635
Queued

kirkmarple-clockgrove wants to merge 5 commits into
mainfrom
fix/635

Conversation

@kirkmarple-clockgrove

Copy link
Copy Markdown
Contributor

Closes #635

What changes

  1. CI waits fold only while consecutive. A CI wait written after a step of another kind is a row of its own, at its own time; consecutive waits still fold into one row (×N). A line written beside a step (aside) opens no row and ends no run of waits.
  2. A CI wait runs from the start of the validation pass that waits. Its row's Took and its bar start at the round's begin line and end at the checks' result. The running card's Now row counts from the same time, so the live and final cards agree.
  3. The review stage's pass for a red required check alone is a fix pass. With nothing to answer but the held red (a PR check's or the merge queue's), the pass runs under pre-review-validation-fix-<n> with a fix step, so the ledger, usdByPass, the card and the report (passes.fix) all count it as a fix. A pass that also answers comments, decisions or a Question stays the answer pass.
  4. The timeline chart (the approved mock-up). One section per table row that took a recorded time, in the table's order, named as its row (a CI wait's with how it ended: CI · passed, CI · red); AI runs active with duration and cost, waits and other steps done, a CI wait that ended red crit. Repeated names are numbered by the builder.

Tests

Three regression tests in plugin/test/progress-card.test.mjs, each failing on main; the chart is pinned in the first. Existing assertions that pinned the old folding and the old chart are updated to the new behaviour.

Checks

Lint; the plugin and bench suites with and without GITHUB_GRAPHQL_URL; the synthetic report oracle 45/45 on seeds 1, 2 and 3.

🤖 Generated with Claude Code

https://claude.ai/code/session_017VqP6hg8ahWzteM9zqi8pU

… a red-only review pass is a fix (#635)

- CI waits fold into one row only while consecutive: a wait after another
  step is a row of its own, in time order.
- A CI wait's row and bar run from the line that began its round (the
  validation pass that waits) to the checks' result; the Now row counts
  from the same time.
- The review stage's pass for a red required check alone (a PR check's or
  the merge queue's) runs under a fix label and a fix step, so the ledger,
  usdByPass, the card and the report count it as a fix.
- The timeline chart has one section per table row, in the table's order
  and named as its row (a CI wait's with how it ended), AI runs amber with
  duration and cost, waits and other steps grey, a red CI wait red.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017VqP6hg8ahWzteM9zqi8pU
…utlasts the reviewer stays one row (#635)

- Steps of any kind fold into one row only while consecutive, so a CI
  loop is a row per wait and a row per fix; each AI run goes to its own
  step's row.
- A wait written while its kind's last wait is still open is that wait
  going on: one row, one wait, its time and its bar counted once.
- The chart numbers a repeated section name before its tail
  ("CI 1 · red", "Fixed CI 2 · Opus 5.5").
- A held red fixed by a fix pass no longer reads as fixed while answering
  the review.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017VqP6hg8ahWzteM9zqi8pU
@kirkmarple-clockgrove
kirkmarple-clockgrove added this pull request to the merge queue Nov 19, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Card timeline: CI waits folded across the fix, each wait timed from its 'waiting' line, and a queue fix pass named and booked as an answer

1 participant