fix(tanstack-ai): enable top-level tree-shaking - #648
Closed
mikemikimike wants to merge 2 commits into
Closed
mikemikimike wants to merge 2 commits into
mikemikimike wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 9908243 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
@cloudflare/tanstack-aipackage exports multiple optional provider adapters from its top-level entry point, but its package metadata does not declare that those modules are side-effect free. Bundlers therefore cannot safely remove unused adapters when consumers import a single factory from the top-level package.This change marks the package as side-effect free so tree-shaking can remove unused adapter modules while preserving the existing top-level and deep-import APIs.
Testing
node node_modules/vitest/vitest.mjs run packages/tanstack-ai/test/package-metadata.test.tsnode node_modules/typescript/bin/tsc --noEmit -p packages/tanstack-ai/tsconfig.jsongit diff --checkThe package-scoped pnpm command is currently blocked on Windows by the repository postinstall invoking
rm -rf; the focused Vitest and TypeScript commands pass independently.Related issue: #609