Repository navigation
[Sandbox] Define terms and fix steps in the migration guide - #34569
Closed
ghostwriternr wants to merge 2 commits into
Closed
ghostwriternr wants to merge 2 commits into
ghostwriternr wants to merge 2 commits into
Conversation
The first migration pages used container application, instance type, interception, snapshot, outbound handler, and restart without saying what they are. The inventory search missed exec(), the move-in step for background processes left readers to work out which parts of two pages to copy, process IDs reached rm -rf unchecked, and several pages restated limits and outcomes that the Containers API owns. Define each term at first use, add exec() and execStream() to the search with its real output, name exactly what to copy, check IDs against one pattern before any process method or rm -rf, and link the owning pages instead of restating them.
The later migration pages used cloudflared, WorkerEntrypoint, props, CA, FUSE, and SquashFS without saying what they are, stated a fixed number of intercept targets and a benchmark figure, and left the API map saying enableInternet has a default. The tunnel cleanup used undeclared shell variables and read only the first page of results, and the OpenCode step clashed with an existing fetch() handler. Define each term at first use, link the intercept limit and the benchmark post instead of numbers, say that every start() passes enableInternet, declare the cleanup variables and page through the results, and route OpenCode from the existing handler.
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://sandbox-audit-migration-clarity.previews.developers.cloudflare.com (commit 3a8d727)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Contributor
Contributor
|
@ghostwriternr This draft pull request has had no activity for 3 days. It will close after 7 days of inactivity. Transition to ready for review if ready. A codeowner can comment |
Contributor
|
@ghostwriternr Closing this draft pull request after 7 days of inactivity. Re-open at a later date and transition to ready for review when you are ready if you seek review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The migration guide used terms such as container application, instance type, interception, outbound handler,
cloudflared,WorkerEntrypoint, and SquashFS before defining them, and several steps did not work as written.Each page now defines a term at first use, and links the page that owns a limit instead of restating it. Other fixes:
exec()andexecStream(), and shows its real output.rm -rf.fetch()handler instead of adding a second one.enableInternethas a default. It now says to pass it on everystart()call.Documentation checklist