Skip to content

Fix Rust JSG union test after Function::call change - #8092

Merged
piscisaureus merged 1 commit into
mainfrom
piscisaureus/fix-oneof-call
Oct 29, 2026
Merged

piscisaureus merged 1 commit into
mainfrom
piscisaureus/fix-oneof-call

Conversation

@piscisaureus

Copy link
Copy Markdown
Contributor

//src/rust/jsg-test does not build on main: #8026 added a test that
calls Function::call::<String>, and #8039, which merged right after
it, made call return a Local<Value> that the caller converts
itself. This converts the result with String::from_js, as the other
callers do.

#8026 added a test that calls `Function::call::<String>`, and #8039
made `call` return a `Local<Value>` that the caller converts itself.
Both merged, so `//src/rust/jsg-test` does not build on main. Convert
the result with `String::from_js`, as the other callers do.
@clanky-the-clanker

Copy link
Copy Markdown

✅ Approved — One-line test fix that restores the build; no findings.

The decision is advisory: this comment never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code reviewer: ✅ LGTM

No issues found.


Reviewed commit: 0819a42a

@piscisaureus
piscisaureus merged commit 5bc9556 into main Oct 29, 2026
37 of 38 checks passed
@piscisaureus
piscisaureus deleted the piscisaureus/fix-oneof-call branch October 29, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants