Repository navigation
Fix Rust JSG union test after Function::call change - #8092
Merged
Merged
Conversation
piscisaureus
requested review from
bartlomieju,
guybedford,
jasnell and
nathanwhit
October 29, 2026 19:33
piscisaureus
enabled auto-merge (squash)
October 29, 2026 19:33
guybedford
approved these changes
Oct 29, 2026
|
✅ Approved — One-line test fix that restores the build; no findings. The decision is advisory: this comment never approves, blocks or requests changes on the pull request. ✅ All checks passed📋 Code reviewer: ✅ LGTMNo issues found. Reviewed commit: |
jasnell
approved these changes
Oct 29, 2026
danlapid
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
//src/rust/jsg-testdoes not build on main: #8026 added a test thatcalls
Function::call::<String>, and #8039, which merged right afterit, made
callreturn aLocal<Value>that the caller convertsitself. This converts the result with
String::from_js, as the othercallers do.