Repository navigation
Add WPT console tests - #8130
Conversation
![clanky-the-clanker[bot]](https://avatars.githubusercontent.com/in/5306670?s=60&v=4){kind=small}
There was a problem hiding this comment.
Superseded by the review of
b739c1df.
This review, of 124f5a57
✅ Approved — No issues found. This adds a WPT target for console. The expected failures are listed explicitly, and the comment in the config explains why they fail.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
The new wpt_test target follows the same pattern as the existing targets in src/wpt/BUILD.bazel. The config in console-test.ts lists each of the 10 expected console-label-conversion failures by name, says why they fail, and leaves out helper.js because it isn't a test.
📝 Documentation: ✅ LGTM
No documentation concerns. The comments in the test config describe how the runtime behaves now.
Reviewed commit: 124f5a57
Run the WPT console suite, which checks that console is a namespace object with the right class string and IDL shape, that it can log symbols and very large arrays, and that historical members are gone. 41 of 51 subtests pass, including all 28 idlharness subtests. The 10 expected failures are all in console-label-conversion: count, countReset, time, timeLog and timeEnd come from V8's builtin console, which doesn't convert object labels with toString() or rethrow errors thrown by that conversion. helper.js is omitted because discovery picks it up although it is not a test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
124f5a5 to
b739c1d
Compare
There was a problem hiding this comment.
✅ Approved — No issues found. The new console WPT target follows the same pattern as the existing targets, and the expected failures are listed by name with the reason they fail.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
The new wpt_test target in src/wpt/BUILD.bazel follows the same pattern as the existing targets there. console-test.ts lists each of the 10 expected console-label-conversion failures by name and says why they fail.
📝 Documentation: ✅ LGTM
No documentation concerns. The comments in the test config describe how the runtime behaves now.
Reviewed commit: b739c1df
Adds a WPT target for
console: 41/51 subtests pass, including all 28 idlharness subtests.The 10 expected failures are in
console-label-conversion: V8's builtincount/time/timeLog/timeEnd/countResetdon't stringify object labels.🤖 Generated with Claude Code