Remove lifecycle_type_backfill job config and BOSH property - #691
Open
WeiQuan0605 wants to merge 1 commit into
Open
WeiQuan0605 wants to merge 1 commit into
WeiQuan0605 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Removes the
cc.lifecycle_type_backfill.frequency_in_secondsBOSH property and its corresponding entry in the cloud_controller_ng.yml.erb template. This job was a one-off backfill introduced to populate NULL lifecycle_type values and is no longer needed.An explanation of the use cases your change solves
Cleans up the temporary backfill job configuration from capi-release once all installations have had sufficient time to run it. Without this change, BOSH would pass a config key to CC that CC no longer recognizes after the corresponding CC change
Links to any other associated PRs
Remove lifecycle_type_backfill job cloud_controller_ng#5401
Enforce lifecycle_type on apps, droplets, and builds cloud_controller_ng#5402
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite