Repository navigation
fix(endpoints): register and message with no endpoints - #6027
Merged
norman-abramovitz merged 3 commits intoOct 19, 2026
Merged
norman-abramovitz merged 3 commits into
norman-abramovitz merged 3 commits into
Conversation
The message stream was assigned in ngAfterViewInit, after the first render. Nothing renders the OnPush view again, so the async pipe never saw the stream and the empty state was blank on Endpoints and Home. Assign it in ngOnInit instead. The Home spec stub gains haveConnected$, which the component now subscribes to.
Register Endpoint sits in the list's sub-nav, and the list renders only when endpoints exist, so the first endpoint could not be registered from the page. The empty branch now renders the sub-nav with a count of 0 above the no-endpoints message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With no endpoints registered, the Endpoints page and Home were blank: no message, and no Register Endpoint button. A new console could not register its first endpoint from the Endpoints page.
Blank message (
fix(endpoints): show the no-endpoints message).app-endpoints-missingassigned its message stream inngAfterViewInit, after the first render. The component is OnPush in a zoneless app, so nothing rendered it again and the async pipe never saw the stream. The stream is now assigned inngOnInit. This also fixes the blank empty state on Home, which uses the same component.No Register button (
fix(endpoints): show Register with no endpoints). Register Endpoint sits in the list's sub-nav, and the list renders only when endpoints exist. The empty branch now renders the same sub-nav, with "Total Endpoints: 0" and the Register button, above the message.Tests. Each fix has a unit test that fails on the code before it and passes after. The Home spec stub gains
haveConnected$, which the component now subscribes to. The touched specs wait withwhenStable()in place ofdetectChanges().make check gatepasses. Checked live with 0 endpoints: the Endpoints page shows the count, the button and the message, and Home shows the message.AI disclosure (RFC-0047): prepared with AI coding assistance; reviewed by the author.