Repository navigation
fix(store): keep observeSignal alive past views - #6030
Merged
norman-abramovitz merged 3 commits intoOct 20, 2026
Merged
norman-abramovitz merged 3 commits into
norman-abramovitz merged 3 commits into
Conversation
The upgrade target can resolve after the user leaves the upgrade page. The constructor subscription was never ended, so a late value set up the version list and loaded versions on a destroyed component. End it with the component (takeUntilDestroyed). The spec now swaps the component's own HelmReleaseHelperService, so the mock is the one the component uses.
With a component's injector, observeSignal made a view effect. It ended with that view and left the observable silent, never complete, so a subscriber that outlived the view (a stepper promise, a snackbar action) would hang. Create the effect on the injector's EnvironmentInjector, so it lives exactly as long as the subscription.
Release note for the signal helper and Helm upgrade fixes.
norman-abramovitz
approved these changes
Oct 20, 2026
norman-abramovitz
left a comment
norman-abramovitz
left a comment
Contributor
There was a problem hiding this comment.
LGTM - Need to see if change will cause issues because the cache needs to be updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6026.
observeSignal(storesignal-interop.ts) bridges a signal to an observable with an effect it destroys on unsubscribe. Given a component's injector, that effect was a view effect: it ended with the view,manualCleanupor not, and the observable then went silent without completing. A subscriber that outlived the view (a stepper promise, a snackbar action) would wait forever.An audit of the 20 callers found none that outlives its view today. Four root services are re-provided by components (
CfRolesService, the CF org/space services,HelmReleaseHelperService,KubernetesNodeService), so their bridges get a component's injector, and a future subscriber of theirs would hang without a trace.EnvironmentInjector, so it lives exactly as long as the subscription. A subscriber that must stop with a view unsubscribes itself.takeUntilDestroyed). Its spec now replaces the component's ownHelmReleaseHelperService, so the mock is the one the component uses.Each fix has a test that fails before it.
Release note:
changelog.d/0014-observe-signal-lifetime.md.AI disclosure (RFC-0047): prepared with AI coding assistance; reviewed by the author.