Skip to content

docs(changelog): name each view the metrics fix restores - #6051

Merged
norman-abramovitz merged 1 commit into
cloudfoundry:developfrom
nabramovitz:norm/docs/metrics-release-note
Oct 23, 2026
Merged

norman-abramovitz merged 1 commit into
cloudfoundry:developfrom
nabramovitz:norm/docs/metrics-release-note

Conversation

@nabramovitz

Copy link
Copy Markdown
Contributor

Summary

Corrects the release note #6050 added. changelog.d/0025-metrics-tab.md said the Metrics tab never appeared on "an application, a Cloud Foundry or a Kubernetes node". The check #6050 fixed, EndpointsService.hasMetrics(), gates four views, and on a Cloud Foundry page it is the Cells tab, not a Metrics tab:

Page View hasMetrics() gates
Application Metrics tab (application-tabs-base.component.ts)
Cloud Foundry Cells tab (cloud-foundry-tabs-base.component.ts)
Kubernetes node Metrics tab (kubernetes-node.component.ts)
Kubernetes resource viewer link to a pod's metrics (kubernetes-resource-viewer.component.ts)

The note now names each one, so a reader looking for the fix finds the view it restores. The second bullet, about the first chart request, is unchanged.

No code changes.

AI disclosure (RFC-0047): prepared with AI coding assistance; reviewed by the author.

The Metrics tab fragment said the tab never appeared on "an
application, a Cloud Foundry or a Kubernetes node". On a Cloud Foundry
page the view hasMetrics() gates is the Cells tab, not a Metrics tab,
and the Kubernetes resource viewer's link to a pod's metrics is gated
the same way. Name each one so the release note matches what a reader
will find.

@norman-abramovitz norman-abramovitz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@norman-abramovitz
norman-abramovitz merged commit 7296eee into cloudfoundry:develop Oct 23, 2026
24 checks passed
@nabramovitz
nabramovitz deleted the norm/docs/metrics-release-note branch October 23, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants