Skip to content

fix(deps): clear the secret-scan and stb vitest findings - #6068

Merged
norman-abramovitz merged 3 commits into
cloudfoundry:developfrom
nabramovitz:norm/fix/secret-scan-alerts
Oct 24, 2026
Merged

norman-abramovitz merged 3 commits into
cloudfoundry:developfrom
nabramovitz:norm/fix/secret-scan-alerts

Conversation

@nabramovitz

Copy link
Copy Markdown
Contributor

Summary

Clears two of the open security findings. The third is handled outside the code.

Finding Change
Secret scanning #80, deploy/proxy.env:3 Deletes the file. Nothing in the repo references it; it is a 2017 docker-compose leftover with a sample DB_PASSWORD.
GHSA-82fw-gwwq-j7x9, vitest in tools/stb Moves vitest, @vitest/browser and @vitest/browser-playwright from 4.1.10 to 4.1.12, the newest 4.x. Dependabot did not raise this one; the root workspace was already on 5.0.5.
Secret scanning #79, deploy/all-in-one/config.all-in-one.properties:11 No change. It is the sample ENCRYPTION_KEY default that the backend already warns about at startup (main.go:631); the alert is dismissed as demonstration data.

Dependabot #1281 (@vitest/ui) was fixed by #6061, which moved the root vitest group to 5.0.5. It closes on the next Dependabot scan.

STB: 61 test files, 601 tests pass; typecheck clean. Docs lint: 60 files, 0 problems.

AI disclosure (RFC-0047): prepared with AI coding assistance; reviewed by the author.

Nothing references deploy/proxy.env; it is a 2017 docker-compose
leftover. Its sample DB_PASSWORD trips secret scanning (alert cloudfoundry#80).
tools/stb pinned vitest 4.1.10, inside GHSA-82fw-gwwq-j7x9 (file read
through the @vitest/mocker redirect mock, fixed in 4.1.11). Move
vitest and its browser packages to 4.1.12, the newest 4.x.

@norman-abramovitz norman-abramovitz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@norman-abramovitz
norman-abramovitz merged commit f3e77a9 into cloudfoundry:develop Oct 24, 2026
24 checks passed
@nabramovitz
nabramovitz deleted the norm/fix/secret-scan-alerts branch October 24, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants