Repository navigation
feat(cluster): add pvcTemplate to storage and walStorage - #1061
Open
kimkroening wants to merge 2 commits into
Open
kimkroening wants to merge 2 commits into
kimkroening wants to merge 2 commits into
Conversation
Signed-off-by: kim.kroening <kim.kroening@campbellsci.ca>
Signed-off-by: kim.kroening <kim.kroening@campbellsci.ca>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
cluster.storage.pvcTemplateandcluster.walStorage.pvcTemplate, passed through to the Cluster'sspec.storage.pvcTemplate/spec.walStorage.pvcTemplate.Addresses #867 (closed by the stale bot). Builds on #577 (no activity).
Why
Some PVC settings can only be expressed through the operator's
pvcTemplate; the chart currently exposes onlysizeandstorageClass. CloudNative Operator is able to handlepvcTemplateif the helm chart passes it through.Changes
templates/cluster.yaml: renderpvcTemplateunderstorageandwalStoragewhen set. Unset renders exactly as before.values.yaml:pvcTemplate: {}for both.values.schema.jsonandREADME.mdregenerated withmake cluster-schema/make docs.test/postgresql-cluster-configuration: the non-default configuration case now setsstorage.pvcTemplate.volumeAttributesClassNameandwalStorage.pvcTemplate.volumeMode, and asserts both on the Cluster spec.Testing
pvcTemplatecontents are applied to PVCs by the Operator.Assisted-by: Claude