Conversation
…t by the operator.
ppxl
left a comment
ppxl
left a comment
There was a problem hiding this comment.
Thanks for the change... again! 💙 😆 I see two things here, mainly the one I have already commented below, and the failing integration test into which you should take a look. Keep in mind though, that for us it suffices to make this dogu v3-ready. But the more we know about upcoming struggles the better...
| @@ -1,5 +1,5 @@ | |||
| #!groovy | |||
| @Library(['github.com/cloudogu/ces-build-lib@5.1.0', 'github.com/cloudogu/dogu-build-lib@v3.5.1', 'github.com/cloudogu/zalenium-build-lib@3092363']) _ | |||
There was a problem hiding this comment.
Here is still zalenium used?? (o_O')
There was a problem hiding this comment.
make no mistake, this dogu maintenance is under the control of the SCM team, so they have their say in selecting a UI int test framework... but still m)
There was a problem hiding this comment.
Jeah, would be difficult for us to change this.
Note to developer to remove the templates when doguctl is no longer used.
Thanks for the comment 👍 How do I run the Integration tests ? But I see that the Jenkins pipeline succeeded. Can you please inform me where the integration tests are failing? |
Remove the unused println
ppxl
left a comment
ppxl
left a comment
There was a problem hiding this comment.
LGTM thanks, thanks for the change 💙
2 participants
No description provided.