Skip to content

chore(deps): upgrade Babel presets to v8.x, remove unused config, and fix ESLint error - #2025

Closed
ArtieReus wants to merge 4 commits into
mainfrom
artie-upgrade-babel-v8
Closed

ArtieReus wants to merge 4 commits into
mainfrom
artie-upgrade-babel-v8

Conversation

@ArtieReus

@ArtieReus ArtieReus commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Upgrade Babel preset packages to version 8.x with explicit configuration for backward compatibility, and clean up unused Babel configuration from the url-state-provider package.

Changes Made

@cloudoperators/juno-ui-components:

  • Upgraded @babel/preset-env from 7.29.7 to 8.0.2
  • Upgraded @babel/preset-react from 7.29.7 to 8.0.1
  • Added explicit runtime: "automatic" for React JSX transform (Babel 8 default, compatible with React 19)
  • Added explicit targets configuration in babel.config.json for test environment (node: "current")
  • Added explicit targets: "defaults" in .storybook/.babelrc for Storybook builds
  • Updated all Babel configs to be compatible with Babel 8 breaking changes

@cloudoperators/juno-url-state-provider:

  • Removed unused babel configuration block from package.json
  • Reason: Vitest uses Vite's built-in esbuild transformer, not Babel. The config was leftover technical debt from the Jest → Vitest migration.

Related Issues

Screenshots (if applicable)

N/A - No visual changes

Testing Instructions

  1. pnpm install
  2. pnpm test - Verify all tests pass (1419 tests in ui-components, 48 in url-state-provider)
  3. pnpm build - Verify builds succeed
  4. pnpm lint - Verify linting passes

Babel 8.0 Breaking Changes Addressed

  • Node.js requirement: ✅ v22.22.2 meets ^22.18.0 || >=24.11.0
  • JSX runtime default change: ✅ Explicitly set runtime: "automatic" (matches Babel 8 default, works with React 19)
  • Browser targets default change: ✅ Explicitly set targets to prevent unexpected compatibility issues
  • ESM module format: ✅ No impact (Vite handles module transformation)

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Copilot AI balanced review requested due to automatic review settings September 30, 2026 09:06
@ArtieReus
ArtieReus requested review from a team and franzheidl as code owners September 30, 2026 09:06
@changeset-bot

changeset-bot Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 662e87d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@cloudoperators/juno-ui-components Patch
@cloudoperators/juno-url-state-provider Patch
@cloudoperators/juno-app-carbon Patch
@cloudoperators/juno-app-doop Patch
@cloudoperators/juno-app-example Patch
@cloudoperators/juno-app-greenhouse Patch
@cloudoperators/juno-app-heureka Patch
@cloudoperators/juno-app-supernova Patch
@cloudoperators/juno-app-template Patch
@cloudoperators/juno-messages-provider Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The changeset inaccurately claims that a package dependency was removed.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

Upgrades UI component Babel presets to v8 and removes obsolete Babel configuration.

Changes:

  • Upgrades Babel presets and configuration.
  • Regenerates dependency resolutions.
  • Applies minor application compatibility fixes.
File Description
pnpm-lock.yaml Updates Babel dependency graph.
packages/​url-state-provider/​package.json Removes obsolete Babel configuration.
packages/​ui-components/​package.json Upgrades Babel presets.
packages/​ui-components/​babel.config.json Adds explicit Babel 8 settings.
packages/​ui-components/​.storybook/​.babelrc Updates Storybook Babel settings.
apps/​supernova/​src/​components/​silences/​SilenceScheduled.tsx Removes the option DOM ID.
apps/​example/​src/​components/​peaks/​list/​PeakDetailsPanelContent.tsx Types the click event.
.changeset/​upgrade-babel-presets.md Documents package changes.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .changeset/upgrade-babel-presets.md Outdated
@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-30 10:47 UTC

Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
Signed-off-by: Arturo Reuschenbach Puncernau <reuschenbach@gmail.com>
@ArtieReus ArtieReus changed the title Artie upgrade babel v8 chore(deps): upgrade Babel presets to v8.x, remove unused config, and fix ESLint error Sep 30, 2026
@ArtieReus ArtieReus self-assigned this Sep 30, 2026
@ArtieReus ArtieReus added the greenhouse-pr-build Set this label to create a preview image which will automatically set the `greenhouse-pr-preview` label Sep 30, 2026
@github-actions github-actions Bot added the greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. label Sep 30, 2026
@ArtieReus
ArtieReus marked this pull request as draft September 30, 2026 09:31
@ArtieReus

Copy link
Copy Markdown
Collaborator Author

lets close it since we might be able to remove them

@ArtieReus ArtieReus closed this Sep 30, 2026
@github-actions github-actions Bot removed the greenhouse-pr-preview THIS LABEL IS SET AUTOMATICALLY. label Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

greenhouse-pr-build Set this label to create a preview image which will automatically set the `greenhouse-pr-preview`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants