Skip to content

chore: upgrade action runtime to Node 24 - #31

Open
John C. Bland II (johncblandii) wants to merge 2 commits into
mainfrom
chore/node24-runtime-upgrade
Open

chore: upgrade action runtime to Node 24#31
John C. Bland II (johncblandii) wants to merge 2 commits into
mainfrom
chore/node24-runtime-upgrade

Conversation

@johncblandii

Copy link
Copy Markdown

what

  • Change the action runtime from node20 to node24 in action.yml

why

  • GitHub is deprecating the Node 20 runtime; actions declaring runs.using: node20 emit a
    deprecation warning for every consumer and are already being force-migrated to Node 24
  • Declaring node24 makes the migration deliberate rather than implicit
  • The committed dist/ bundle is unchanged (no source changes);
    it was smoke-tested locally under Node 24, and this repo's integration tests exercise the bundle
    end-to-end via uses: ./ on this PR, now running on Node 24

references

@johncblandii John C. Bland II (johncblandii) added the patch A minor, backward compatible change label Aug 12, 2026
Copilot AI lite review requested due to automatic review settings August 12, 2026 20:28
@johncblandii John C. Bland II (johncblandii) added the patch A minor, backward compatible change label Aug 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates this GitHub Action’s declared runtime to align with GitHub Actions runner deprecations and ensure consumers no longer receive Node 20 deprecation warnings.

Changes:

  • Changed runs.using from node20 to node24 in action.yml.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@johncblandii

Copy link
Copy Markdown
Author

Note: the failing CI / test checks are a pre-existing test-harness issue, not a runtime regression. In each test workflow the set_status job fails with "Input required and not supplied: token" (repo secret/vars not reaching the workflow_dispatch context), so the commit status the action waits for is never created and the wait times out by design. The action itself ran correctly under Node 24 in these runs — it polled the expected status 5 times and exited on the retry cap. The same CI has been red on all Renovate branches since June.

PUBLIC_REPO_ACCESS_TOKEN no longer exists, so the set_status jobs
failed with 'Input required and not supplied: token' and every wait
timed out. The default token with statuses: write can set commit
statuses on this repo.
@johncblandii

Copy link
Copy Markdown
Author

Fixed the pre-existing test-harness failure in this PR (37c3057): the set_status jobs referenced secrets.PUBLIC_REPO_ACCESS_TOKEN, which no longer exists, so the commit status was never created and every wait timed out. They now use the default GITHUB_TOKEN with an explicit statuses: write permission block — sufficient for setting commit statuses on the same repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch A minor, backward compatible change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants