Skip to content

fix: compile themeable package to CommonJS so it is importable #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amanabiy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: compile themeable package to CommonJS so it is importable #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/package-json.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ function themablePackage() {
exports: {
".": {
types: "./theming.d.ts",
import: "./theming.js",
default: "./theming.js",
},
},
});
Expand Down
4 changes: 2 additions & 2 deletions src-themeable/theming.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import { preset, TypedOverride } from "./internal/template/internal/generated/th
const internalDir = join(__dirname, "./internal");
const scssDir = join(internalDir, "./scss");
const templateDir = join(internalDir, "./template");
const designTokensTemplateDir = join(internalDir, "./template-tokens");

export type Theme = TypedOverride;
export interface BuildThemedComponentsParams {
Expand All @@ -25,9 +24,10 @@ export function buildThemedComponents({ theme, outputDir, baseThemeId }: BuildTh
preset,
baseThemeId,
componentsOutputDir: join(outputDir, "components"),
// The chat components reuse the core design tokens and ship no
// design-tokens template, so designTokensTemplateDir is omitted.
designTokensOutputDir: join(outputDir, "design-tokens"),
templateDir,
designTokensTemplateDir,
scssDir,
});
}
4 changes: 2 additions & 2 deletions tsconfig.src-themeable.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"compilerOptions": {
"lib": ["es2019", "dom", "dom.iterable"],
"target": "ES2019",
"module": "ESNext",
"moduleResolution": "nodenext",
"module": "CommonJS",
"moduleResolution": "node16",
"rootDir": "src-themeable",
"declaration": true,
"incremental": true,
Expand Down
Loading