Skip to content

chore: Add heros - #5065

Draft
at-susie wants to merge 5 commits into
mainfrom
dev-v3-ienakaai-thumbnail
Draft

at-susie wants to merge 5 commits into
mainfrom
dev-v3-ienakaai-thumbnail

Conversation

@at-susie

Copy link
Copy Markdown
Member

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.70%. Comparing base (708448a) to head (723e99c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5065   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files         990      990           
  Lines       31813    31818    +5     
  Branches    11750    11752    +2     
=======================================
+ Hits        31084    31089    +5     
  Misses        722      722           
  Partials        7        7           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@at-susie
at-susie force-pushed the dev-v3-ienakaai-thumbnail branch from bdd3f40 to 80d61ff Compare October 7, 2026 08:07
Axe reported five violations on #/light/heroshot/overview:

- button-name (6 nodes): icon-only dismiss and copy buttons had no
  accessible name. Added copyButtonAriaLabel to CopyToClipboard,
  dismissLabel to the dismissible Flashbar item, and dismissLabel to
  Token and every TokenGroup item.
- label (4 nodes): added ariaLabel to the standalone Input and to
  PromptInput, and filteringAriaLabel to TextFilter and PropertyFilter.
- label-title-only: covered by the TextFilter filteringAriaLabel.
- heading-order: the page h1 was followed by h3, so the Box heroshot now
  uses variant h2 and the TextContent heroshot an h2.
- landmark-unique: labelled the BreadcrumbGroup nav landmark.

Verified with axe-core using the spec from src/__a11y__/axe.ts: zero
violations in both light and dark.

This branch was successfully deployed

3 active deployments
dev-pages-react18 — 9cc3eeca Deployed Oct 7, 2026 by at-susie via deploy (React 18) / deploy #2582
dev-pages-react16 — 9cc3eeca Deployed Oct 7, 2026 by at-susie via deploy (React 16) / deploy #2582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant