Skip to content

chore: Add visual test definition for token - #5109

Merged
NathanZlion merged 1 commit into
mainfrom
dev-v3-natidere-token-visual-tests
Oct 7, 2026
Merged

NathanZlion merged 1 commit into
mainfrom
dev-v3-natidere-token-visual-tests

Conversation

@NathanZlion

@NathanZlion NathanZlion commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Description

Token had no visual regression tests. This adds a visual test definition covering the existing token/permutations and token/style-permutations pages, following the same shape as control-group.ts.

Related #5090.

How has this been tested?

  • gulp build passes locally
  • generate-visual-tests produces test/visual/token.test.ts for the new definition
  • Visual regression workflow on this PR captures the baselines

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Oct 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.70%. Comparing base (ea381b7) to head (04f967f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5109   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files         990      990           
  Lines       31811    31811           
  Branches    11748    11748           
=======================================
  Hits        31082    31082           
  Misses        722      722           
  Partials        7        7           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NathanZlion
NathanZlion added this pull request to the merge queue Oct 7, 2026
Merged via the queue into main with commit 3b62c18 Oct 7, 2026
73 checks passed
@NathanZlion
NathanZlion deleted the dev-v3-natidere-token-visual-tests branch October 7, 2026 13:22

This branch was successfully deployed

3 active deployments
dev-pages-react16 — 04f967f9 Deployed Oct 6, 2026 by NathanZlion via deploy (React 16) / deploy #2559
dev-pages-react18 — 04f967f9 Deployed Oct 6, 2026 by NathanZlion via deploy (React 18) / deploy #2559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants