Repository navigation
chore: Sync Sorted i18n messages - #5118
Merged
Merged
Conversation
NathanZlion
changed the title
NathanZlion
commented
Oct 8, 2026
| @@ -1,685 +1,687 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
| /* eslint-disable prettier/prettier */ | |||
Member
Author
There was a problem hiding this comment.
Added for the sake of ensuring the internal build output which has double quotes doesn't get formatted back to single quote here by prettier and making noisy diffs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5118 +/- ##
=======================================
Coverage 97.70% 97.70%
=======================================
Files 990 990
Lines 31818 31818
Branches 11752 11752
=======================================
Hits 31089 31089
Misses 722 722
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
NathanZlion
commented
Oct 8, 2026
| "i18nStrings.slashedMonthConstraintText": "Pour le mois, utilisez le format MM/AAAA.", | ||
| "i18nStrings.isoMonthConstraintText": "Pour le mois, utilisez le format MM-AAAA.", | ||
| "i18nStrings.isoDateTimeConstraintText": "Pour la date, utilisez le format AAAA-MM-JJ. Pour l’heure, utilisez le format 24 heures.", | ||
| "i18nStrings.isoMonthConstraintText": "Pour le mois, utilisez le format AAAA-MM.", |
Member
Author
There was a problem hiding this comment.
changed to AAAA-MM because year always comes first regardless, also reflected internally
srungta08
approved these changes
Oct 8, 2026
NathanZlion
marked this pull request as ready for review
October 8, 2026 08:50
NathanZlion
changed the title
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 8, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Major change here is the sorting of translation keys. This is following internal updates to make output sorted to avoid arbitrary insertion of keys and a slow drift between components and internal i18n package. This helps make it sort of deterministic.
This PR syncs the sorting change and also changes to existing strings that were made but didn't get synced here because they weren't owned by anyone after first translation.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.