-
Notifications
You must be signed in to change notification settings - Fork 43
feat(ENG-14143): adding checks for colour and interactivity suppression #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
coillteoir
wants to merge
1
commit into
master
Choose a base branch
from
pr402
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| from enum import Flag, auto | ||
| from typing import ClassVar | ||
|
|
||
| import pytest | ||
|
|
||
| from cloudsmith_cli.core.utils import ( | ||
| ColorMode, | ||
| TTYMode, | ||
| color_enabled, | ||
| is_interactive, | ||
| ) | ||
|
|
||
|
|
||
| class Desired(Flag): | ||
| NONE = 0 | ||
| COLOR = auto() | ||
| INTERACTIVE = auto() | ||
|
|
||
|
|
||
| class TestTerminalUISuppression: | ||
| """Testing precedence in environment variables for controlling interactivity and colour""" | ||
|
|
||
| env_tests: ClassVar[list] = [ | ||
| pytest.param( | ||
| {}, | ||
| ColorMode.AUTO, | ||
| TTYMode.ENABLED, | ||
| Desired.COLOR | Desired.INTERACTIVE, | ||
| id="default behaviour", | ||
| ), | ||
| pytest.param( | ||
| {}, | ||
| ColorMode.NEVER, | ||
| TTYMode.DISABLED, | ||
| Desired.NONE, | ||
| id="force disable tty and color mode", | ||
| ), | ||
| pytest.param( | ||
| {"NO_COLOR": ""}, | ||
| ColorMode.AUTO, | ||
| TTYMode.ENABLED, | ||
| Desired.COLOR | Desired.INTERACTIVE, | ||
| id="empty no color var", | ||
| ), | ||
| pytest.param( | ||
| {"CLOUDSMITH_FORCE_COLOR": "true"}, | ||
| ColorMode.AUTO, | ||
| TTYMode.ENABLED, | ||
| Desired.COLOR | Desired.INTERACTIVE, | ||
| id="force ANSI output", | ||
| ), | ||
| pytest.param( | ||
| {"NO_COLOR": "true", "CLOUDSMITH_FORCE_COLOR": "true"}, | ||
| ColorMode.AUTO, | ||
| TTYMode.ENABLED, | ||
| Desired.INTERACTIVE, | ||
| id="force ANSI output, respects NO_COLOR", | ||
| ), | ||
| pytest.param( | ||
| {"TERM": "dumb"}, | ||
| ColorMode.AUTO, | ||
| TTYMode.ENABLED, | ||
| Desired.INTERACTIVE, | ||
| id="no color enabled for TERM=dumb", | ||
| ), | ||
| pytest.param( | ||
| {"CI": "true"}, | ||
| ColorMode.AUTO, | ||
| TTYMode.ENABLED, | ||
| Desired.COLOR, | ||
| id="in a CI server, do not use interactive features", | ||
| ), | ||
| pytest.param( | ||
| {"CI": "true", "NO_COLOR": "true"}, | ||
| ColorMode.AUTO, | ||
| TTYMode.ENABLED, | ||
| Desired.NONE, | ||
| id="suppress interactivity and colour", | ||
| ), | ||
| pytest.param( | ||
| { | ||
| "NO_COLOR": "true", | ||
| "TERM": "dumb", | ||
| "CLOUDSMITH_FORCE_COLOR": "true", | ||
| }, | ||
| ColorMode.AUTO, | ||
| TTYMode.ENABLED, | ||
| Desired.INTERACTIVE, | ||
| id="test NO_COLOR always respected", | ||
| ), | ||
| pytest.param( | ||
| { | ||
| "TERM": "dumb", | ||
| "CLOUDSMITH_FORCE_COLOR": "true", | ||
| }, | ||
| ColorMode.AUTO, | ||
| TTYMode.ENABLED, | ||
| Desired.COLOR | Desired.INTERACTIVE, | ||
| id="ensure force tty respected over term dumb", | ||
| ), | ||
| ] | ||
|
|
||
| @pytest.mark.parametrize("env,colorMode,ttyMode,desired", env_tests) | ||
| def test_no_color_environment_variables( | ||
| self, | ||
| env: dict[str, str], | ||
| colorMode: ColorMode, | ||
| ttyMode: TTYMode, | ||
| desired: Desired, | ||
| ): | ||
| want_color = Desired.COLOR in desired | ||
| assert color_enabled(env, colorMode, ttyMode) == want_color, ( | ||
| f"colour suppression check failed for environment: {env} wanted {desired}" | ||
| ) | ||
|
|
||
| @pytest.mark.parametrize("env,colorMode,ttyMode,desired", env_tests) | ||
| def test_no_interactive_environment_variables( | ||
| self, env, colorMode, ttyMode, desired | ||
| ): | ||
| want_interactive = Desired.INTERACTIVE in desired | ||
| assert is_interactive(env, ttyMode) == want_interactive, ( | ||
| f"interactive suppression check failed for environment {env} wanted {desired}" | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.