add MSBuild projects for the libraries an MSVC ffmpeg build needs - #4
Open
adipose wants to merge 1 commit into
Open
add MSBuild projects for the libraries an MSVC ffmpeg build needs#4adipose wants to merge 1 commit into
adipose wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_ffmpeg_msvc.sh can't enable dav1d, speex, opencore-amr, libxml2 or bzlib, because the only copies we ship are the MinGW archives under thirdparty, which link.exe can't read. So an MSVC ffmpeg has no software AV1 decoder at all: the native av1 decoder is hwaccel only, it returns 0 frames.
These are MSBuild projects for those five, four as submodules pinned to release tags and opencore-amr vendored since it has no git repo. They write bin_\lib next to LAV's own libraries.
They're in the solution but not built by Release or Debug, which keep using the prebuilt archives. A new
Release MSVCconfiguration builds them, which is what you suggested. I didn't add a separate CLANG one because the libraries are identical either way, the compiler choice belongs to build_ffmpeg_msvc.sh. Happy to add it if you'd rather have both.Built Release x64 here. Wiring them into build_ffmpeg_msvc.sh is the next step, I wanted this looked at first.