Add a Blocked tile to the Overview - #10
Merged
Merged
Conversation
Jobs held by a concurrency limit were invisible on the Overview: the backlog read as ready + scheduled, so operators had to open the Jobs list to find out how much work was actually left. Blocked jobs are work the application still owes, so they belong in the tile row. Seven tiles no longer fit the six-column grid at every width, so the row is seven across on a wide screen and drops to four (4 + 3) below 1320px, which is where "PROCESSED · 24H" starts wrapping. Closes cmer#9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9.
Jobs held by a concurrency limit were invisible on the Overview: the backlog read as ready + scheduled, so you had to open the Jobs list to find out how much work was actually left. Blocked jobs are work the application still owes, so they belong in the tile row.
Changes
Flightdeck::Overviewgains ablockedcount (SolidQueue::BlockedExecution, through the same cachedcountedhelper as every other tile) and ablocked_tileslotted between "Ready now" and "Scheduled". The detail line reads "held by concurrency limits", or "nothing blocked" at zero..fd-grid-2keeps its own 1080px breakpoint.docs/screenshots, changelog entry under[Unreleased].overview_test.rb,nested_mount_test.rbandsystem/dashboard_test.rb, plus a new assertion that the tile reports the real blocked count.Verification
bin/test(both host modes): 277 runs, 0 failuresbundle exec rake test:system: 13 runs, 0 failuresbundle exec rubocopclean,bundle exec rake assets:checkfreshNot included
Queue depth on the Queues panel still counts ready executions only, so a queue with blocked work shows a smaller depth than the tile implies. Widening that changes latency semantics too, so it seemed like a separate call — happy to fold it in if you'd rather.
🤖 Generated with Claude Code