Repository navigation
Realign two eval cases with the mislabels #22 corrected - #23
Merged
Merged
Conversation
#20 built 13 cases from a blind-router baseline's misses. #22 then re-examined two of those misses, found them mislabelled, and replaced the queries in the two plugins' `evals/trigger-queries.json`. The committed cases were not moved with them, so they asserted conclusions this repo had already rejected -- `make eval` would have spent real money proving the wrong thing. Each case is rebuilt around its plugin's replacement query. Still 13 cases; no description, skill body or `trigger-queries.json` was touched. - agent-ellis, `ticket-acceptance` -> `clean-enough-to-land`. Rebuilt on `is this branch clean enough to land -- quality, tests and acceptance`. The `pr-flow` exclusion grader is dropped rather than carried over: it recorded a baseline measured against the query #22 reclassified as pr-flow's own ground, no baseline has measured the new query, and nothing in the new turn names an issue, a pull request or a reviewer comment. Asserting silence on an unmeasured confusion would risk failing a correctly routed run, which is the reason `sketch-before-building` already omits two graders. The reason is recorded in `fires.md` instead. - agent-smith, `agreed-design-run-it` -> `agreed-design-break-into-units`. Rebuilt on `we agreed the design -- now break it into units and run the iterations`. Still no `agent-hale` exclusion grader: #20 omitted one because smith dispatches hale by design, and the new query strengthens that -- running the iterations *is* dispatching hale per unit. The old rationale cited the baseline miss that #22 reclassified, so it was rewritten. `Ward` was also dropped from the turn; it is an installed skill's name and had no business steering a case that asserts a different skill. Both turns keep the register of the other eleven -- a concrete situation with something to act on, the query as the closing sentence -- and neither carries its skill's name or its description's wording. Grader `input_match` keeps the repo's no-closing-quote spelling, which a real run confirmed reports `Skill called 1x` correctly. Refs: #13, #14 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while checking the suite before spending money on the first
make evalrun.Two cases asserted what this repo has since rejected
#20 built 13 cases from the blind-router baseline's misses. #22 then re-examined two of those misses and concluded they were mislabels, replacing the queries in the plugins'
trigger-queries.json. The cases were not updated, so they contradicted the sets beside them.agent-ellis/ticket-acceptancePLAN.md, not a ticket.agent-smith/agreed-design-run-itLeft alone, the first
make evalrun would have paid to assert both and failed correctly, for a reason unrelated to routing health.The fix
Each case is rebuilt around its plugin's replacement query, as a realistic turn — a bare query does not fire a skill, which was measured (
Skill called 0xfor a bare string,1xfor the same intent in a real turn). Still 13 cases; the directories are renamed because the name is the case name in the report.agent-ellis/clean-enough-to-land— finished branch, tests, acceptance criteria inPLAN.md, asking for quality/tests/acceptance together before merge. That combination on finished work is ellis's gate rather than any one of the three alone.agent-smith/agreed-design-break-into-units— a settled design split into five units with an ordering between them, asking to break it up and run the iterations. The scope is the differentiator, and it is stated in the prompt rather than implied.Both dropped their exclusion grader, each for a stated reason
The reasons are written into the grader bodies, which the CLI prints in its report:
input_matchkeeps the repo's no-closing-quote spelling, which a real run settled: it reportedSkill called 1xcorrectly, where the closing-quote variant risks everyfiresgrader reporting 0 and everydoes-not-firegrader passing trivially.Versions
Nothing moves. An
evals/change is neither theSKILL.mdbody nor catalogue copy.Checks
make test— all four pass.bash scripts/validate-fixtures— all fixtures behaved as expected.make evaldeliberately not run here.🤖 Generated with Claude Code