Skip to content

Realign two eval cases with the mislabels #22 corrected - #23

Merged
cmj0121 merged 1 commit into
mainfrom
fix/realign-two-eval-cases
Sep 16, 2026
Merged

cmj0121 merged 1 commit into
mainfrom
fix/realign-two-eval-cases

Conversation

@cmj0121

@cmj0121 cmj0121 commented Sep 16, 2026

Copy link
Copy Markdown
Owner

Found while checking the suite before spending money on the first make eval run.

Two cases asserted what this repo has since rejected

#20 built 13 cases from the blind-router baseline's misses. #22 then re-examined two of those misses and concluded they were mislabels, replacing the queries in the plugins' trigger-queries.json. The cases were not updated, so they contradicted the sets beside them.

case asserted what #22 concluded
agent-ellis/ticket-acceptance ellis fires, pr-flow silent, on "does this change do what the ticket asked" pr-flow is right. Its Phase 2 is literally "Compare what the branch does with what the issue asked for", its description says it checks the diff against the issue body, and its own train half already carried the same question. Ellis's Phase 5 verifies against PLAN.md, not a ticket.
agent-smith/agreed-design-run-it smith fires, on "we agreed the design, now run the implementation" agent-hale is right. That query names the act of implementing with an approach already settled — hale's description verbatim — and carries none of the scope or coordination that distinguishes smith.

Left alone, the first make eval run would have paid to assert both and failed correctly, for a reason unrelated to routing health.

The fix

Each case is rebuilt around its plugin's replacement query, as a realistic turn — a bare query does not fire a skill, which was measured (Skill called 0x for a bare string, 1x for the same intent in a real turn). Still 13 cases; the directories are renamed because the name is the case name in the report.

  • agent-ellis/clean-enough-to-land — finished branch, tests, acceptance criteria in PLAN.md, asking for quality/tests/acceptance together before merge. That combination on finished work is ellis's gate rather than any one of the three alone.
  • agent-smith/agreed-design-break-into-units — a settled design split into five units with an ordering between them, asking to break it up and run the iterations. The scope is the differentiator, and it is stated in the prompt rather than implied.

Both dropped their exclusion grader, each for a stated reason

The reasons are written into the grader bodies, which the CLI prints in its report:

input_match keeps the repo's no-closing-quote spelling, which a real run settled: it reported Skill called 1x correctly, where the closing-quote variant risks every fires grader reporting 0 and every does-not-fire grader passing trivially.

Versions

Nothing moves. An evals/ change is neither the SKILL.md body nor catalogue copy.

Checks

make test — all four pass. bash scripts/validate-fixtures — all fixtures behaved as expected. make eval deliberately not run here.

🤖 Generated with Claude Code

#20 built 13 cases from a blind-router baseline's misses. #22 then re-examined two of
those misses, found them mislabelled, and replaced the queries in the two plugins'
`evals/trigger-queries.json`. The committed cases were not moved with them, so they
asserted conclusions this repo had already rejected -- `make eval` would have spent real
money proving the wrong thing. Each case is rebuilt around its plugin's replacement
query. Still 13 cases; no description, skill body or `trigger-queries.json` was touched.

- agent-ellis, `ticket-acceptance` -> `clean-enough-to-land`. Rebuilt on `is this branch
  clean enough to land -- quality, tests and acceptance`. The `pr-flow` exclusion grader
  is dropped rather than carried over: it recorded a baseline measured against the query
  #22 reclassified as pr-flow's own ground, no baseline has measured the new query, and
  nothing in the new turn names an issue, a pull request or a reviewer comment. Asserting
  silence on an unmeasured confusion would risk failing a correctly routed run, which is
  the reason `sketch-before-building` already omits two graders. The reason is recorded
  in `fires.md` instead.

- agent-smith, `agreed-design-run-it` -> `agreed-design-break-into-units`. Rebuilt on `we
  agreed the design -- now break it into units and run the iterations`. Still no
  `agent-hale` exclusion grader: #20 omitted one because smith dispatches hale by design,
  and the new query strengthens that -- running the iterations *is* dispatching hale per
  unit. The old rationale cited the baseline miss that #22 reclassified, so it was
  rewritten. `Ward` was also dropped from the turn; it is an installed skill's name and
  had no business steering a case that asserts a different skill.

Both turns keep the register of the other eleven -- a concrete situation with something
to act on, the query as the closing sentence -- and neither carries its skill's name or
its description's wording. Grader `input_match` keeps the repo's no-closing-quote
spelling, which a real run confirmed reports `Skill called 1x` correctly.

Refs: #13, #14

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@cmj0121
cmj0121 merged commit dab7767 into main Sep 16, 2026
2 checks passed
@cmj0121
cmj0121 deleted the fix/realign-two-eval-cases branch September 16, 2026 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant