Repository navigation
feat: implement CRC rollback on failure + DryRun Cleanup - #1463
Merged
juliusclausnitzer merged 17 commits intoNov 17, 2026
Merged
Conversation
Signed-off-by: juliusclausnitzer <julius.clausnitzer@sap.com>
juliusclausnitzer
marked this pull request as ready for review
November 4, 2026 13:33
juliusclausnitzer
requested review from
PhilippMatthes,
SoWieMarkus,
auhlig,
mblos and
umswmayj
as code owners
November 4, 2026 13:33
Signed-off-by: juliusclausnitzer <julius.clausnitzer@sap.com>
…n-failure-and-dry-run # Conflicts: # internal/scheduling/nova/plugins/filters/filter_quota_enforcement_test.go
Signed-off-by: juliusclausnitzer <julius.clausnitzer@sap.com>
Signed-off-by: juliusclausnitzer <julius.clausnitzer@sap.com>
mblos
requested changes
Nov 11, 2026
mblos
left a comment
Collaborator
There was a problem hiding this comment.
Overall solid, somme suggestions:
- RollbackStartedAt → Restoring condition
- We drop pass 2 in the restore phase. Its sufficient to write the spec of the CRs
- some refactoring: extract shared reconcileRestore, fold terminateWithRollbackFailed into advanceTo via a reason param
- I think we should add some small guards in the reconciler:
- DryRun=true + AllowRejection=false silently commits; a guard would reject this combination
- DryRun=true and non empty SnapshotBefore means existing CRs would be mutated, something we don't want to have: a guard would reject when a dry run modified existing CRs
Signed-off-by: juliusclausnitzer <julius.clausnitzer@sap.com>
mblos
previously approved these changes
Nov 17, 2026
mblos
left a comment
Collaborator
There was a problem hiding this comment.
Some small refactorings left..
also a test case for the following is missing: CR deleted → rollback re-creates
Signed-off-by: juliusclausnitzer <julius.clausnitzer@sap.com>
Contributor
Test Coverage ReportTest Coverage 📊: 72.2% |
PhilippMatthes
approved these changes
Nov 17, 2026
juliusclausnitzer
deleted the
wm-780-crc-rollback-on-failure-and-dry-run
branch
November 17, 2026 14:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
restoreFromSnapshot: a shared two-pass (write → settle) helper that converges affectedCommittedResources back to the pre-changeSnapshotBeforestate; idempotent and crash-safereconcileRollingBack: on CR rejection or scheduling timeout, restores the snapshot and terminates asRejected; on permanent restore failure (timeout) terminatesRejectedwith reasonRollbackFailedreconcileDryRunCleanup: for a would-accept dry-run, restores the snapshot and terminates asAccepted(schedulability verdict preserved); a would-reject dry-run routes throughRollingBack→RejectedRollbackStartedAtstatus timestamp to measureRollbackTimeoutfrom phase entry rather than theProgressingcondition'sLastTransitionTime(which only updates on status flips)RollbackTimeoutreconciler knob andChangeReasonRollbackFailed