Repository navigation
(CR) Refactor: split CR and reservation reconciler functions + fix IsReady short-circuit - #1534
Merged
Merged
Conversation
mblos
commented
Nov 16, 2026
Collaborator
- Split long reconcile functions in the CR controller and reservation controller into focused helpers; prep for fix: prevent nil pointer panic in feature mode override guard #789/fix: capacity filter correctly accounts for multi-VM CR reservation slots #784
- Fix IsReady short-circuit in reservation_controller: when spec changes increment the generation, skip the early-return and fall through to the full reconcile path so observedGeneration is updated correctly; previously the CR controller could get stuck in Reserving after a spec update
- Prefer fewest vCPUs when sizing reservation slots in variable-ratio flavor groups, to avoid blocking CPU for placements that need fewer cores
Signed-off-by: Marcel <156897072+mblos@users.noreply.github.com>
Signed-off-by: Marcel <156897072+mblos@users.noreply.github.com>
Signed-off-by: Marcel <156897072+mblos@users.noreply.github.com>
Signed-off-by: Marcel <156897072+mblos@users.noreply.github.com>
Signed-off-by: Marcel <156897072+mblos@users.noreply.github.com>
…ke the smallest CPU portion instead of largest CPU portion Signed-off-by: Marcel <156897072+mblos@users.noreply.github.com>
mblos
requested review from
PhilippMatthes,
SoWieMarkus,
auhlig,
juliusclausnitzer and
umswmayj
as code owners
November 16, 2026 10:07
mblos
enabled auto-merge (squash)
November 16, 2026 10:07
Signed-off-by: Marcel <156897072+mblos@users.noreply.github.com>
Contributor
Test Coverage ReportTest Coverage 📊: 72.2% |
PhilippMatthes
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.