Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 71 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,76 @@
# Changelog

## cortex 0.9.2

### Fixes

- **More stable E2E tests** ([#1538](https://github.com/cobaltcore-dev/cortex/pull/1538)): E2E subcommands now get a default zap logger initialized early in `main()`, preventing log output from being silently discarded before the flag-configured logger is set up. Flavor-group extraction now logs skip counters (`skippedParseErr`, `skippedNoHWVersion`, `skippedInvalidGroup`) and a summary line at extraction completion for easier diagnosis of data-quality issues in CI. Key success-path log lines in commitment E2E checks have been promoted from `V(1)` (debug) to `Info` level so they appear in standard CI output. A new panic on internal dry-run errors (`"internal error processing dry-run request"`) catches controller timeouts and misconfigurations immediately instead of falling through to the generic rejection handler.

### Documentation

- **Add missing plugin entries & fix stale option reference** ([#1533](https://github.com/cobaltcore-dev/cortex/pull/1533)): Added 3 missing plugin entries to nova smart-scheduling docs (`filter_failover_host`, `weigher_failover_host`, `kvm_cr_migration_slot`) and updated the filter count from "seventeen" to "nineteen". Fixed stale reference to `ignoredReservationTypes` → `AssumeEmptyHosts: true` in failover host reservations docs.

### Dependency Updates

| Dependency | Old | New | Note |
|---|---|---|---|
| `kube-prometheus-stack` | `v93.3.0` | `v93.3.1` | Helm chart |

## cortex-postgres 0.6.34

- Bump to align with cortex 0.9.2 release.

## cortex-shim 0.1.40

- Bump to align with cortex 0.9.2 release.

## bundles 0.0.116

- Bump to align with cortex 0.9.2 release.

## cortex-placement-shim 0.1.40

- Bump to align with cortex 0.9.2 release.

## Release PR [#1540](https://github.com/cobaltcore-dev/cortex/pull/1540) — 2026-11-17

### Bumped Versions

| Package | Previous | New |
|---|---|---|
| cortex | 0.9.1 | 0.9.2 |
| cortex-postgres | 0.6.33 | 0.6.34 |
| cortex-shim | 0.1.39 | 0.1.40 |
| bundles | 0.0.115 | 0.0.116 |
| cortex-placement-shim | 0.1.39 | 0.1.40 |

### Bug Fixes

- **More stable E2E tests** — Default zap logger for E2E subcommands prevents silently discarded log output. Flavor-group extraction now logs skip counters and a summary line. Commitment E2E check success-path logs promoted to `Info` level. New panic on internal dry-run errors catches controller timeouts immediately.

### Documentation

- **Missing plugin entries & stale option reference** — Added `filter_failover_host`, `weigher_failover_host`, `kvm_cr_migration_slot` to nova smart-scheduling docs (filter count "seventeen" → "nineteen"). Fixed `ignoredReservationTypes` → `AssumeEmptyHosts: true` in failover host reservations docs.

### Chores

- **Bump app version** — `sha-bac55e3a` → `sha-cdb4dfaa` in `helm/library/cortex/Chart.yaml`.

### Dependency Updates

| Dependency | Old | New | Note |
|---|---|---|---|
| `kube-prometheus-stack` | `v93.3.0` | `v93.3.1` | Helm chart |

### ⚠️ Operational Notes

1. **No schema or RBAC changes:** Rolling upgrade is sufficient.
2. **Dry-run panic:** E2E tests will now panic immediately on internal dry-run errors that were previously silently swallowed. If CI failures surface from this path, investigate controller timeouts or misconfigurations rather than reverting.

**Contributors:** @mblos, @cortex-ai-agents[bot], @renovate[bot], @SoWieMarkus

**PR:** [#1540](https://github.com/cobaltcore-dev/cortex/pull/1540) | **Commits:** 4 | **Files changed:** 7 | **+35 / −12**

## cortex 0.9.1

### Refactoring
Expand Down
5 changes: 5 additions & 0 deletions cmd/manager/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,11 @@ func main() {
SetOverrideUserAgent(mainConfig.UserAgent.Component, mainConfig.UserAgent.Version)
sso.SetUserAgent(mainConfig.UserAgent.Component, mainConfig.UserAgent.Version)

// E2E subcommands return before the flag-configured logger is set up below.
// Set a default logger now so e2e log output is not silently discarded;
// the controller path will override it with the flag-configured zap instance.
ctrl.SetLogger(zap.New())

// Custom entrypoint for scheduler e2e tests.
// Usage: /main <subcommand> [json-override]
// The optional json-override is merged on top of the ConfigMap config, e.g.:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ selection, so a KVM request never runs a VMware weigher and vice versa.

## The filters

Nova ships seventeen filters (registered under `internal/scheduling/nova/plugins/filters/`). Filters run
Nova ships nineteen filters (registered under `internal/scheduling/nova/plugins/filters/`). Filters run
sequentially and each removes hosts that fail its rule:

| Filter | Removes hosts that… |
Expand All @@ -72,6 +72,7 @@ sequentially and each removes hosts that fail its rule:
| `filter_allowed_projects` | are not allowed for the request's project |
| `filter_external_customer` | violate external-customer isolation rules |
| `filter_domain_pinning` | are not among a pinned domain's dedicated hypervisors |
| `filter_failover_host` | are reserved as failover landing zones (non-evacuation), or are not the selected failover target (evacuation) |
| `filter_instance_group_affinity` | break a required instance-group affinity |
| `filter_instance_group_anti_affinity` | break a required instance-group anti-affinity |
| `filter_live_migratable` | cannot accept a live-migratable instance |
Expand All @@ -95,7 +96,10 @@ They split by hypervisor family:
- `kvm_failover_reservation_consolidation` — consolidate to preserve failover headroom.
- `kvm_failover_evacuation` — bias placement during evacuation to keep failover capacity (see
[Failover reservations](../03-reservations-and-inventory/03-failover-reservations.md)).
- `kvm_cr_migration_slot` — boost hosts that can accommodate a migrating VM's committed-resource reservation slot.
- `kvm_instance_group_soft_affinity` — honor *soft* instance-group affinity as a preference.
- `weigher_failover_host` — lift the selected failover target host to the front during gang evacuation (see
[Failover host reservations](../03-reservations-and-inventory/04-failover-host-reservations.md)).

**VMware weighers:**

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -530,11 +530,11 @@ is held back so a *second*, concurrent host failure still has its own free landi
it already consumed. Keeping `h3` and `h4` means that if the evacuation onto `h1` fails, Nova retries onto an
ordinary host instead of being forced onto an unmatched reserved slot.

The filter also honors the **call-time** `ignoredReservationTypes` request option. This is what keeps the
**path finder probe** working: the probe asks the scheduler which hosts would accept a flavor, and it passes
`ignoredReservationTypes: [FailoverHostReservation]` precisely so a reserved host is *not* hidden from its own
partition. Because the filter obeys that option, the probe still discovers already-reserved hosts and the
partitioning does not fragment.
The filter also honors the **call-time** `AssumeEmptyHosts` request option. This is what keeps the
**path finder probe** working: the probe asks the scheduler which hosts would accept a flavor, and it sets
`AssumeEmptyHosts: true` so candidates are judged by total capacity with every reservation ignored — a
reserved host is *not* hidden from its own partition. Because the filter skips all failover-host blocking
under that option, the probe still discovers already-reserved hosts and the partitioning does not fragment.

### The weigher: lift the selected target to the front

Expand Down
8 changes: 4 additions & 4 deletions helm/bundles/cortex-cinder/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,23 @@ apiVersion: v2
name: cortex-cinder
description: A Helm chart deploying Cortex for Cinder.
type: application
version: 0.0.115
version: 0.0.116
appVersion: 0.1.0
dependencies:
# from: file://../../library/cortex-postgres
- name: cortex-postgres
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.6.33
version: 0.6.34

# from: file://../../library/cortex
- name: cortex
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.9.1
version: 0.9.2
alias: cortex-knowledge-controllers
# from: file://../../library/cortex
- name: cortex
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.9.1
version: 0.9.2
alias: cortex-scheduling-controllers

# Owner info adds a configmap to the kubernetes cluster with information on
Expand Down
4 changes: 2 additions & 2 deletions helm/bundles/cortex-crds/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ apiVersion: v2
name: cortex-crds
description: A Helm chart deploying Cortex CRDs.
type: application
version: 0.0.115
version: 0.0.116
appVersion: 0.1.0
dependencies:
# from: file://../../library/cortex
- name: cortex
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.9.1
version: 0.9.2

# Owner info adds a configmap to the kubernetes cluster with information on
# the service owner. This makes it easier to find out who to contact in case
Expand Down
4 changes: 2 additions & 2 deletions helm/bundles/cortex-ironcore/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ apiVersion: v2
name: cortex-ironcore
description: A Helm chart deploying Cortex for IronCore.
type: application
version: 0.0.115
version: 0.0.116
appVersion: 0.1.0
dependencies:
# from: file://../../library/cortex
- name: cortex
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.9.1
version: 0.9.2

# Owner info adds a configmap to the kubernetes cluster with information on
# the service owner. This makes it easier to find out who to contact in case
Expand Down
8 changes: 4 additions & 4 deletions helm/bundles/cortex-manila/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,23 @@ apiVersion: v2
name: cortex-manila
description: A Helm chart deploying Cortex for Manila.
type: application
version: 0.0.115
version: 0.0.116
appVersion: 0.1.0
dependencies:
# from: file://../../library/cortex-postgres
- name: cortex-postgres
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.6.33
version: 0.6.34

# from: file://../../library/cortex
- name: cortex
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.9.1
version: 0.9.2
alias: cortex-knowledge-controllers
# from: file://../../library/cortex
- name: cortex
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.9.1
version: 0.9.2
alias: cortex-scheduling-controllers

# Owner info adds a configmap to the kubernetes cluster with information on
Expand Down
8 changes: 4 additions & 4 deletions helm/bundles/cortex-nova/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,23 @@ apiVersion: v2
name: cortex-nova
description: A Helm chart deploying Cortex for Nova.
type: application
version: 0.0.115
version: 0.0.116
appVersion: 0.1.0
dependencies:
# from: file://../../library/cortex-postgres
- name: cortex-postgres
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.6.33
version: 0.6.34

# from: file://../../library/cortex
- name: cortex
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.9.1
version: 0.9.2
alias: cortex-knowledge-controllers
# from: file://../../library/cortex
- name: cortex
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.9.1
version: 0.9.2
alias: cortex-scheduling-controllers

# Owner info adds a configmap to the kubernetes cluster with information on
Expand Down
4 changes: 2 additions & 2 deletions helm/bundles/cortex-placement-shim/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ apiVersion: v2
name: cortex-placement-shim
description: A Helm chart deploying the Cortex placement shim.
type: application
version: 0.1.39
version: 0.1.40
appVersion: 0.1.0
dependencies:
# from: file://../../library/cortex-shim
- name: cortex-shim
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.1.39
version: 0.1.40
# Owner info adds a configmap to the kubernetes cluster with information on
# the service owner. This makes it easier to find out who to contact in case
# of issues. See: https://github.com/sapcc/helm-charts/pkgs/container/helm-charts%2Fowner-info
Expand Down
4 changes: 2 additions & 2 deletions helm/bundles/cortex-pods/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ apiVersion: v2
name: cortex-pods
description: A Helm chart deploying Cortex for Pods.
type: application
version: 0.0.115
version: 0.0.116
appVersion: 0.1.0
dependencies:
# from: file://../../library/cortex
- name: cortex
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.9.1
version: 0.9.2

# Owner info adds a configmap to the kubernetes cluster with information on
# the service owner. This makes it easier to find out who to contact in case
Expand Down
2 changes: 1 addition & 1 deletion helm/dev/cortex-prometheus-operator/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ dependencies:
# CRDs of the prometheus operator, such as PrometheusRule, ServiceMonitor, etc.
- name: kube-prometheus-stack
repository: oci://ghcr.io/prometheus-community/charts
version: 93.3.0
version: 93.3.1
2 changes: 1 addition & 1 deletion helm/library/cortex-postgres/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ apiVersion: v2
name: cortex-postgres
description: Postgres setup for Cortex.
type: application
version: 0.6.33
version: 0.6.34
appVersion: "sha-f69b58ee"
2 changes: 1 addition & 1 deletion helm/library/cortex-shim/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: cortex-shim
description: A Helm chart to distribute cortex shims.
type: application
version: 0.1.39
version: 0.1.40
appVersion: "sha-01a68db0"
icon: "https://example.com/icon.png"
dependencies: []
4 changes: 2 additions & 2 deletions helm/library/cortex/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: cortex
description: A Helm chart to distribute cortex.
type: application
version: 0.9.1
appVersion: "sha-bac55e3a"
version: 0.9.2
appVersion: "sha-cdb4dfaa"
icon: "https://example.com/icon.png"
dependencies: []
12 changes: 12 additions & 0 deletions internal/knowledge/extractor/plugins/compute/flavor_groups.go
Original file line number Diff line number Diff line change
Expand Up @@ -139,20 +139,23 @@ func (e *FlavorGroupExtractor) Extract() ([]plugins.Feature, error) {

// Group flavors by flavorGroupIdentifierName
groupMap := make(map[string][]FlavorInGroup)
var skippedParseErr, skippedNoHWVersion int

for _, row := range rows {
// Parse extra_specs JSON
var extraSpecs map[string]string
if row.ExtraSpecs != "" {
if err := json.Unmarshal([]byte(row.ExtraSpecs), &extraSpecs); err != nil {
flavorGroupLog.V(1).Info("failed to parse extra_specs for flavor", "flavor", row.Name, "error", err)
skippedParseErr++
continue
}
}

hwVersion, exists := extraSpecs["quota:hw_version"]
if !exists || hwVersion == "" {
flavorGroupLog.V(1).Info("flavor missing hw_version extra_spec", "flavor", row.Name)
skippedNoHWVersion++
continue
}

Expand All @@ -175,6 +178,7 @@ func (e *FlavorGroupExtractor) Extract() ([]plugins.Feature, error) {

// Convert map to features
features := make([]FlavorGroupFeature, 0, len(groupMap))
var skippedInvalidGroup int
for groupName, flavors := range groupMap {
if len(flavors) == 0 {
continue
Expand Down Expand Up @@ -243,6 +247,7 @@ func (e *FlavorGroupExtractor) Extract() ([]plugins.Feature, error) {
}
if err := fg.Validate(); err != nil {
flavorGroupLog.Error(err, "skipping flavor group with invalid data", "groupName", groupName)
skippedInvalidGroup++
continue
}
features = append(features, fg)
Expand All @@ -253,6 +258,13 @@ func (e *FlavorGroupExtractor) Extract() ([]plugins.Feature, error) {
return features[i].Name < features[j].Name
})

flavorGroupLog.Info("flavor group extraction complete",
"totalFlavors", len(rows),
"skippedParseError", skippedParseErr,
"skippedNoHWVersion", skippedNoHWVersion,
"skippedInvalidGroup", skippedInvalidGroup,
"groups", len(features))

return e.Extracted(features)
}

Expand Down
Loading
Loading