Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,22 @@
# Changelog

## cortex 0.9.4

### Bug Fixes

- **Fix false host oversubscription alerts after capacity refactoring** ([#1543](https://github.com/cobaltcore-dev/cortex/pull/1543), @mblos)
After the unified capacity calculation refactoring (#1504), every host with committed-resource reservations **and** running VMs was incorrectly reported as oversubscribed. This patch corrects the false-positive alerting logic in the host oversubscription controller.

### Helm Chart Versions

| Chart | Version |
|---|---|
| cortex | 0.9.4 |
| cortex-postgres | 0.6.36 |
| cortex-shim | 0.1.42 |
| bundles | 0.0.118 |
| cortex-placement-shim | 0.1.42 |

## Changelog — cortex 0.9.3

**Release PR:** [#1545](https://github.com/cobaltcore-dev/cortex/pull/1545)
Expand Down
12 changes: 11 additions & 1 deletion api/v1alpha1/committed_resource_change_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@ const (
// ChangeConditionFinished is True once the change request has reached a terminal phase.
ChangeConditionFinished = "Finished"

// ChangeConditionRestoring is True while the change request is restoring pre-change state
// (RollingBack or DryRunCleanup). Its LastTransitionTime marks when restore began and its
// Message carries the last restore error (e.g. a transient k8s API error).
ChangeConditionRestoring = "Restoring"

// Reasons for ChangeConditionProgressing=False (non-terminal problems).
ChangeReasonStalled = "Stalled"
ChangeReasonTimedOut = "TimedOut"
Expand All @@ -58,6 +63,11 @@ const (
ChangeRequestReasonAccepted = "Accepted"
ChangeRequestReasonRejected = "Rejected"
ChangeRequestReasonSuperseded = "Superseded"
// ChangeReasonRollbackFailed is the Finished reason when rollback exhausted its timeout.
ChangeReasonRollbackFailed = "RollbackFailed"
// ChangeReasonInvalidSpec is the Finished reason when a change request is rejected for a
// malformed spec (e.g. a dry run that would commit or mutate existing commitments).
ChangeReasonInvalidSpec = "InvalidSpec"
)

// CommittedResourceChangeSpec defines the desired change for a CommittedResourceChange.
Expand Down Expand Up @@ -110,7 +120,7 @@ type CommittedResourceChangeStatus struct {
// +kubebuilder:validation:Optional
UpsertedCommitments []corev1.ObjectReference `json:"upsertedCommitments,omitempty"`

// Conditions holds Progressing and Finished conditions.
// Conditions holds Progressing, Finished and Restoring conditions.
// +kubebuilder:validation:Optional
Conditions []metav1.Condition `json:"conditions,omitempty" patchStrategy:"merge" patchMergeKey:"type"`

Expand Down
8 changes: 4 additions & 4 deletions helm/bundles/cortex-cinder/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,23 @@ apiVersion: v2
name: cortex-cinder
description: A Helm chart deploying Cortex for Cinder.
type: application
version: 0.0.117
version: 0.0.118
appVersion: 0.1.0
dependencies:
# from: file://../../library/cortex-postgres
- name: cortex-postgres
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.6.35
version: 0.6.36

# from: file://../../library/cortex
- name: cortex
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.9.3
version: 0.9.4
alias: cortex-knowledge-controllers
# from: file://../../library/cortex
- name: cortex
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.9.3
version: 0.9.4
alias: cortex-scheduling-controllers

# Owner info adds a configmap to the kubernetes cluster with information on
Expand Down
4 changes: 2 additions & 2 deletions helm/bundles/cortex-crds/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ apiVersion: v2
name: cortex-crds
description: A Helm chart deploying Cortex CRDs.
type: application
version: 0.0.117
version: 0.0.118
appVersion: 0.1.0
dependencies:
# from: file://../../library/cortex
- name: cortex
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.9.3
version: 0.9.4

# Owner info adds a configmap to the kubernetes cluster with information on
# the service owner. This makes it easier to find out who to contact in case
Expand Down
4 changes: 2 additions & 2 deletions helm/bundles/cortex-ironcore/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ apiVersion: v2
name: cortex-ironcore
description: A Helm chart deploying Cortex for IronCore.
type: application
version: 0.0.117
version: 0.0.118
appVersion: 0.1.0
dependencies:
# from: file://../../library/cortex
- name: cortex
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.9.3
version: 0.9.4

# Owner info adds a configmap to the kubernetes cluster with information on
# the service owner. This makes it easier to find out who to contact in case
Expand Down
8 changes: 4 additions & 4 deletions helm/bundles/cortex-manila/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,23 @@ apiVersion: v2
name: cortex-manila
description: A Helm chart deploying Cortex for Manila.
type: application
version: 0.0.117
version: 0.0.118
appVersion: 0.1.0
dependencies:
# from: file://../../library/cortex-postgres
- name: cortex-postgres
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.6.35
version: 0.6.36

# from: file://../../library/cortex
- name: cortex
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.9.3
version: 0.9.4
alias: cortex-knowledge-controllers
# from: file://../../library/cortex
- name: cortex
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.9.3
version: 0.9.4
alias: cortex-scheduling-controllers

# Owner info adds a configmap to the kubernetes cluster with information on
Expand Down
8 changes: 4 additions & 4 deletions helm/bundles/cortex-nova/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,23 @@ apiVersion: v2
name: cortex-nova
description: A Helm chart deploying Cortex for Nova.
type: application
version: 0.0.117
version: 0.0.118
appVersion: 0.1.0
dependencies:
# from: file://../../library/cortex-postgres
- name: cortex-postgres
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.6.35
version: 0.6.36

# from: file://../../library/cortex
- name: cortex
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.9.3
version: 0.9.4
alias: cortex-knowledge-controllers
# from: file://../../library/cortex
- name: cortex
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.9.3
version: 0.9.4
alias: cortex-scheduling-controllers

# Owner info adds a configmap to the kubernetes cluster with information on
Expand Down
4 changes: 2 additions & 2 deletions helm/bundles/cortex-placement-shim/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ apiVersion: v2
name: cortex-placement-shim
description: A Helm chart deploying the Cortex placement shim.
type: application
version: 0.1.41
version: 0.1.42
appVersion: 0.1.0
dependencies:
# from: file://../../library/cortex-shim
- name: cortex-shim
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.1.41
version: 0.1.42
# Owner info adds a configmap to the kubernetes cluster with information on
# the service owner. This makes it easier to find out who to contact in case
# of issues. See: https://github.com/sapcc/helm-charts/pkgs/container/helm-charts%2Fowner-info
Expand Down
4 changes: 2 additions & 2 deletions helm/bundles/cortex-pods/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ apiVersion: v2
name: cortex-pods
description: A Helm chart deploying Cortex for Pods.
type: application
version: 0.0.117
version: 0.0.118
appVersion: 0.1.0
dependencies:
# from: file://../../library/cortex
- name: cortex
repository: oci://ghcr.io/cobaltcore-dev/cortex/charts
version: 0.9.3
version: 0.9.4

# Owner info adds a configmap to the kubernetes cluster with information on
# the service owner. This makes it easier to find out who to contact in case
Expand Down
2 changes: 1 addition & 1 deletion helm/library/cortex-postgres/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ apiVersion: v2
name: cortex-postgres
description: Postgres setup for Cortex.
type: application
version: 0.6.35
version: 0.6.36
appVersion: "sha-f69b58ee"
2 changes: 1 addition & 1 deletion helm/library/cortex-shim/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: cortex-shim
description: A Helm chart to distribute cortex shims.
type: application
version: 0.1.41
version: 0.1.42
appVersion: "sha-01a68db0"
icon: "https://example.com/icon.png"
dependencies: []
4 changes: 2 additions & 2 deletions helm/library/cortex/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: cortex
description: A Helm chart to distribute cortex.
type: application
version: 0.9.3
appVersion: "sha-67c88600"
version: 0.9.4
appVersion: "sha-96a0f8cd"
icon: "https://example.com/icon.png"
dependencies: []
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,8 @@ spec:
of a CommittedResourceChange.
properties:
conditions:
description: Conditions holds Progressing and Finished conditions.
description: Conditions holds Progressing, Finished and Restoring
conditions.
items:
description: Condition contains details for one aspect of the current
state of this API Resource.
Expand Down
Loading
Loading