Skip to content

WIP: Add HypervisorConfigSet and HypervisorConfigOverride CRDs - #329

Draft
fwiesel wants to merge 2 commits into
mainfrom
hypervisor-config-sets-and-override
Draft

fwiesel wants to merge 2 commits into
mainfrom
hypervisor-config-sets-and-override

Conversation

@fwiesel

@fwiesel fwiesel commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Work in progress — not ready for review.

Introduces two new CRDs for per-hypervisor configuration management:

  • HypervisorConfigSet: a named template of config values that can be applied to a set of hypervisors
  • HypervisorConfigOverride: per-hypervisor overrides on top of a ConfigSet

Wires the override lookup into HypervisorController so that per-node config values are resolved at reconcile time.

Depends on: ssa (#302).

@coderabbitai

coderabbitai Bot commented Jul 8, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: aa928e0c-c10f-430f-a89d-bda8d6744490

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hypervisor-config-sets-and-override

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@fwiesel
fwiesel force-pushed the ssa branch 2 times, most recently from 4c09880 to 9d785cb Compare July 9, 2026 17:56
@fwiesel
fwiesel force-pushed the hypervisor-config-sets-and-override branch 3 times, most recently from 9124365 to f1e3eef Compare July 13, 2026 12:18
@fwiesel
fwiesel force-pushed the ssa branch 3 times, most recently from b2fd489 to ad93c0b Compare July 13, 2026 19:59
Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
@fwiesel
fwiesel changed the base branch from ssa to main November 13, 2026 20:48
@fwiesel
fwiesel force-pushed the hypervisor-config-sets-and-override branch from f1e3eef to f41bb3e Compare November 13, 2026 20:48
Standard Kubernetes label selector descriptions in generated CRD YAML
use 'ANDed' (e.g. 'matchExpressions are ANDed'), which the typos checker
flags as a misspelling of 'Dead'.

Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
@fwiesel
fwiesel force-pushed the hypervisor-config-sets-and-override branch from f41bb3e to 1c0642c Compare November 13, 2026 21:30
@github-actions

Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/internal 0.00% (ø)
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 75.43% (ø)
Coverage details

Compared to commit cfee313 (run #43438290245)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1/hypervisor_config_override_types.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1/hypervisor_config_set_types.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/api/v1/zz_generated.deepcopy.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/hypervisorconfigoverride.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/hypervisorconfigoverridespec.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/hypervisorconfigoverridestatus.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/hypervisorconfigset.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/hypervisorconfigsetspec.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/hypervisorconfigsetstatus.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/hypervisorconfigsettemplate.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/api/v1/hypervisorconfigspec.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/internal/internal.go 0.00% (ø) 6 0 6
github.com/cobaltcore-dev/openstack-hypervisor-operator/applyconfigurations/utils.go 0.00% (ø) 0 0 0
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/hypervisor_controller.go 80.00% (ø) 120 96 24

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant