Repository navigation
Conversation
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
03d7f37 to
2a49eb5
Compare
|
This PR is stale because it has been open for 45 days with no activity. |
Replace MergeFromWithOptimisticLock + retry with Status().Apply() for all eviction status updates. The evictionStatusCfg helper seeds every apply with the full set of owned fields so SSA never prunes values between reconcile cycles. As the sole owner of every condition on the Eviction CR, the reconciler seeds all three condition types on each apply. The apply configuration constructor for the cluster-scoped Eviction resource takes only a name (no namespace). Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
Replace PatchHypervisorStatusWithRetry with Status().Apply() for the InternalIP scalar and ConditionTypeTerminating condition. Re-fetch the hypervisor after the status apply so the subsequent spec patch sees a fresh resourceVersion. Seed the conditions this controller writes (Terminating and AgentPodsEvicted) so SSA does not claim ownership over conditions written by other controllers. InternalIP falls back to hypervisor.Status.InternalIP when the node reports no NodeInternalIP. Combined with ForceOwnership, seeding nothing would prune a previously stored valid IP during transient node states such as kubelet restarts or bootstrap. The AgentPodsEvicted=False branch previously returned early with a requeue before running syncLabelsAndAnnotations, so node label changes were not propagated to the Hypervisor while terminating. Move the requeue after the spec patch so labels stay in sync. Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
Replace PatchHypervisorStatusWithRetry with Status().Apply() for the ConditionTypeTainted condition. Only ConditionTypeTainted is seeded into the apply so SSA does not claim ownership over conditions written by other controllers. Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
Replace PatchHypervisorStatusWithRetry with Status().Apply() for the ConditionTypeOffboarded condition. Seed only that condition so SSA does not claim ownership over conditions written by other controllers. Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
Replace PatchHypervisorStatusWithRetry with Status().Apply() for ConditionTypeAggregatesUpdated and the Aggregates slice. The error path includes the current Aggregates in the apply to prevent SSA from pruning previously-set values on a transient OpenStack error. Clearing aggregates to an empty slice uses a targeted merge patch to work around the omitempty limitation in the generated apply configuration type. Seed only ConditionTypeAggregatesUpdated so SSA does not claim ownership over conditions written by other controllers. Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
Replace PatchHypervisorStatusWithRetry with Status().Apply() for ConditionTypeReady. Seed only that condition so SSA does not claim ownership over conditions written by other controllers. Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
With all controllers migrated to Status().Apply(), the last caller of PatchHypervisorStatusWithRetry is gone. Remove the helper and the StatusPatchBackoff it used. Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
Merging this branch changes the coverage (2 decrease, 2 increase)
Coverage detailsCompared to commit cfee313 (run #43438290245)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files:
|
With all controllers migrated to
Status().Apply(), the last caller ofPatchHypervisorStatusWithRetryis gone. Remove the helper and theStatusPatchBackoffit used.This PR must merge last, after all controller-migration PRs are merged:
ssa-conditions-helpersssa-evictionssa-hypervisor-controllerssa-hypervisor-taintssa-hypervisor-maintenancessa-onboardingssa-offboardingssa-aggregatesssa-traitsssa-readyssa-node-certificateThe GitHub PR view will show this branch as containing all those commits until they merge into main, at which point only the
internal/utils/status_patch.godeletion remains.