Repository navigation
Fix make generate and run go-makefile-maker - #387
Merged
Merged
Conversation
fwiesel
force-pushed
the
fix-makefile-generate
branch
2 times, most recently
from
November 9, 2026 13:55
fddab47 to
b240479
Compare
Closed
A go-makefile-maker run dropped the quoting around the release-scoped ClusterRole name, breaking make generate and the pre-commit make check hook. The quoting now lives in the configured value itself, so future regenerations keep a working Makefile. Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
fwiesel
force-pushed
the
fix-makefile-generate
branch
from
November 9, 2026 14:26
b240479 to
0cf45f3
Compare
mchristianl
approved these changes
Nov 9, 2026
bashar-alkhateeb
approved these changes
Nov 9, 2026
BzzyBriel
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make generate— and with it the pre-commitmake checkhook — fails since the last go-makefile-maker run: the configured RBAC role name is embedded into the Makefile verbatim, without the quoting the invocation needs.The quoting now lives in the configured value itself, so regenerations keep a working Makefile. The second commit runs go-makefile-maker to update the autogenerated workflows.