Repository navigation
Conversation
fwiesel
force-pushed
the
fix/offboarding-requeue-and-rp-cleanup
branch
from
November 17, 2026 11:35
f5cad1c to
5706250
Compare
fwiesel
force-pushed
the
fix/offboarding-requeue-and-rp-cleanup
branch
from
November 17, 2026 12:04
5706250 to
4f808f3
Compare
fwiesel
force-pushed
the
fix/offboarding-requeue-and-rp-cleanup
branch
from
November 17, 2026 12:27
4f808f3 to
52fdfcf
Compare
fwiesel
force-pushed
the
fix/offboarding-requeue-and-rp-cleanup
branch
2 times, most recently
from
November 17, 2026 13:35
bcdf352 to
146748c
Compare
When an OpenStack API call failed during offboarding, setOffboardingCondition recorded the error in the status condition and returned a nil error. Once a subsequent reconcile produced the same condition message, the status update became a no-op, emitted no watch event, and offboarding stopped retrying. Return the OpenStack error so controller-runtime retries failed calls with backoff. Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
Deleting the compute service also removes the hypervisor record in Nova. If resource provider cleanup fails on the same reconcile, the next reconcile receives ErrNoHypervisor and previously marked the hypervisor offboarded without cleaning up Placement. Fall back to Status.HypervisorID so the resource provider is still cleaned up, and skip cleanup when Placement already returns NotFound. Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
fwiesel
force-pushed
the
fix/offboarding-requeue-and-rp-cleanup
branch
from
November 17, 2026 13:44
146748c to
9c91095
Compare
|
Caution No coverage for base commit 2bf2f58 was found, so this report compares against its ancestor c80f288 (1 commit earlier) Merging this branch will increase overall coverage
Coverage detailsCompared to commit c80f288 (run #44076257257)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an OpenStack API call failed during offboarding,
setOffboardingConditionrecorded the error in the status condition and returnedctrl.Result{}, nil. Once a subsequent reconcile produced the same error message, the status update became a no-op, emitted no watch event, and offboarding stopped retrying. Return the OpenStack error so controller-runtime retries failed calls with backoff.Deleting the compute service also removes the hypervisor record in Nova. If resource provider cleanup fails on the same reconcile, the next retry receives
ErrNoHypervisorand previously marked the hypervisor offboarded without cleaning up Placement. Fall back toStatus.HypervisorIDso resource provider cleanup still runs on retry.