Skip to content

Watch all lifecycle-relevant Hypervisor conditions - #396

Open
fwiesel wants to merge 1 commit into
mainfrom
fix/gardener-node-lifecycle-watch-predicates
Open

fwiesel wants to merge 1 commit into
mainfrom
fix/gardener-node-lifecycle-watch-predicates

Conversation

@fwiesel

@fwiesel fwiesel commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

GardenerNodeLifecycleController reads Onboarding, Evicting, Offboarded, and HaEnabled from Hypervisor status, but its watch predicate only checked Evicting. Check all four conditions in the watch predicate so status-only transitions update the blocking PodDisruptionBudget and signalling Deployment without waiting for an unrelated Node event.

@fwiesel
fwiesel force-pushed the fix/gardener-node-lifecycle-watch-predicates branch from bdec5bb to 5367384 Compare November 17, 2026 11:36
GardenerNodeLifecycleController reads Onboarding, Evicting, Offboarded, and
HaEnabled from Hypervisor status, but its watch predicate only checked
Evicting. Status-only transitions on the other conditions were dropped,
leaving the blocking PodDisruptionBudget and signalling Deployment stale
until an unrelated Node event occurred. Check all four conditions in the
watch predicate.

Signed-off-by: Fabian Wiesel <fabian.wiesel@sap.com>
@fwiesel
fwiesel force-pushed the fix/gardener-node-lifecycle-watch-predicates branch from 5367384 to b905aca Compare November 17, 2026 12:05
@github-actions

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 76.62% (+1.19%) 👍
Coverage details

Compared to commit c80f288 (run #44076257257)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/gardener_node_lifecycle_controller.go 76.67% (+12.71%) 90 (+4) 69 (+14) 21 (-10) 🎉

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files:

  • github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/gardener_node_lifecycle_controller_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant