Repository navigation
Refactor VM CRD conditions and spec - #12
Open
PhilippMatthes wants to merge 4 commits into
Open
PhilippMatthes wants to merge 4 commits into
PhilippMatthes wants to merge 4 commits into
Conversation
Signed-off-by: Philipp Matthes <p.matthes@sap.com>
PhilippMatthes
force-pushed
the
refactor-vm-crd-conditions-and-spec
branch
from
November 17, 2026 08:36
275bc4e to
0020c58
Compare
Signed-off-by: Philipp Matthes <p.matthes@sap.com>
Signed-off-by: Philipp Matthes <p.matthes@sap.com>
Signed-off-by: Philipp Matthes <p.matthes@sap.com>
PhilippMatthes
marked this pull request as ready for review
November 17, 2026 13:29
PhilippMatthes
requested review from
PaulPickhardt and
mchristianl
as code owners
November 17, 2026 13:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor VM lifecycle and source-sync conditions, remove spec.targetHost, and add optional project-domain ownership and Cortex transition metadata. Correct stale printer columns and selectable fields, validate non-negative observed generations, and regenerate the CRD YAML and deepcopy code with make.
Update Nova synchronization and tests for the revised API, preserving Cortex-provided domains and the ServerGone signal used by garbage collection. Extend YAML validation fixtures without adding CRD Go tests. Generation, lint, and Go tests pass; kind-based CRD validation is blocked because Docker is not running.