Fix warnings - #393
Open
Jordan08 wants to merge 3 commits into
Open
Conversation
…tation of the slice method in SlicedTube was returning a reference to a Slice object that was created from a shared pointer to a TSlice object. However, the shared pointer was being created with a custom deleter that did nothing, which meant that the TSlice object was never deleted, leading to a memory leak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
J'ai développé avec Clang-18 et plein d'option de Debug et de track de memory leak
ça a révelé beaucoup de warnings et de perte de memoire.
J'ai fixé l'intégralité de ce que j'ai trouvé.
template
concept IsIntervalDomain = codac2::is_interval_based::value;
//concept IsIntervalDomain = std::is_same_v<Scalar,codac2::Interval>;
Avec le Scalar, ça permet d'avoir une compatibilité avec le type Affine que je veux intégrer, sans rien changer au comportement actuelle.
..