Repository navigation
fix(connect-ip): handle quic-go HTTPStream takeover errors - #57
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the genuine source failure exposed when GitHub Actions were reactivated for the fork. The previous
connect-ip-goproxy code assumedhttp3.HTTPStreamer.HTTPStream()returned only*http3.Stream. With the mergedquic-go v0.65.0dependency, the method returns(*http3.Stream, error), and the maingo build ./...failed withassignment mismatch: 1 variable but ... returns 2 values.Capture and propagate the stream-takeover error instead of constructing a connection from an invalid stream. Preserve the existing HTTP 200 header and successful connection path. No dependency, API, or CI-policy changes in this PR.
Focused local verification on Acer against current
origin/mainatb33a5a9:go build -trimpath ./...,go vet ./...,go test ./...(all main-module packages) andgofmt/git diff --checkpassed with Go 1.27.3. CI now dispatches again after the GitHub Actions fork reactivation; require the complete GitHubLint and testcheck before merging.Following this source fix, rebase/update central Renovate-policy PR #56 onto main and rerun its CI, which previously failed on the same pre-existing source issue.