Skip to content

chore(desktop): drop the app.css pointer-cursor rule once @codeatlasdev/ui ships it #117

Closed

Description

@mvilacad

atlas#116 adds one zero-specificity :where() rule to apps/desktop/src/app.css that gives enabled buttons and role controls cursor: pointer (project avatars in SpaceDots showed the arrow).

The kit is adding the same thing in @layer ca.reset: codeatlasdev/ui#552 (closes ui#549). When a released @codeatlasdev/ui has it:

  • bump @codeatlasdev/ui in apps/desktop
  • delete the rule in app.css and src/lib/pointerCursor.test.ts (replace with one test that a role=tab button computes pointer under the real kit CSS)
  • remove the matching CHANGELOG wording if the rule is no longer ours

Blocker to check first: as written, #552's rule does not win in a native-feel app. base.css (@layer ca.base, a later layer than ca.reset) has html[data-ca-native] :is(button, a, nav, header, label, [role=button], [role=tab], [role=menuitem], [role=option]) { cursor: default } and Atlas calls nativeFeel(). Probe in Chromium with the kit's real base.css: data-ca-native off -> pointer, on -> default. Do not delete the app rule until a probe with data-ca-native set returns pointer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions