Skip to content

test:changed --land: dist counts as fresh when it predates the rebase #591

Closed

Description

@mvilacad

The land gate decides whether to rebuild packages/ui/dist and site/dist by comparing their mtime with the files in the PR diff. A rebase brings in package sources the diff does not list, so a dist built hours earlier (before the rebase) is judged fresh and the site build fails (MISSING_EXPORT ChartScope on #579) or tests run against old code. In land mode the gate must always rebuild both (it already budgets for it).

Activity

  1. added
    bugSomething isn't working
    in progressSomeone is working on it (see the linked draft PR)
    on Oct 25, 2026
  2. self-assigned this
    on Oct 25, 2026
  3. mvilacad commented on Oct 25, 2026

    @mvilacad
    ContributorAuthor

    Working on this in #592 (draft). Branch fix/591-test-changed-land-dist-counts-as. Regression test first, then the fix.

  4. removed
    in progressSomeone is working on it (see the linked draft PR)
    on Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions