Skip to content

refactor: export VISUAL_ROUTES from route-impact.ts and import it in pages.visual.spec #651

New issue
New issue
Closed
#658
Closed
refactor: export VISUAL_ROUTES from route-impact.ts and import it in pages.visual.spec#651
#658
Assignees
mvilacad
Labels
area:teststest infra, flakes, CI

Description

@mvilacad
mvilacad
opened on Oct 25, 2026

VISUAL_ROUTES in scripts/test-changed.ts and PAGES in site/tests/pages.visual.spec.ts are two copies kept 'in step' by a comment (TruthAudit). One export in scripts/route-impact.ts, imported by both.

Activity

  1. mvilacad
    added
    area:teststest infra, flakes, CI
    in progressSomeone is working on it (see the linked draft PR)
    on Oct 25, 2026
  2. mvilacad
    self-assigned this
    on Oct 25, 2026

  3. mvilacad commented on Oct 25, 2026

    @mvilacad
    mvilacad
    on Oct 25, 2026
    ContributorAuthor

    Working on this in #658 (draft). Branch fix/651-refactor-export-visual-routes-from-route. Regression test first, then the fix.

  4. mvilacad
    added 2 commits that reference this issue on Oct 26, 2026

    chore: start #651

    1d064e0

    refactor: VISUAL_ROUTES lives in route-impact.ts and the visual spec …

    c81164e
  5. mvilacad
    closed this as completedin #658on Oct 26, 2026
  6. mvilacad
    removed
    in progressSomeone is working on it (see the linked draft PR)
    on Oct 26, 2026
  7. Nitjsefnie
    added a commit that references this issue on Oct 26, 2026

    fix: refactor: export VISUAL_ROUTES from route-impact.ts and import i…

    496fc2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:teststest infra, flakes, CI

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions