Skip to content

fix: route-impact: a CLI source under packages/ui/bin selects every docs route #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvilacad merged 2 commits into from
Oct 25, 2026
Merged

fix: route-impact: a CLI source under packages/ui/bin selects every docs route #594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ab1939
chore: start #593
mvilacad Oct 25, 2026
9169c90
fix: a CLI source under packages/ui/bin selects no docs route (#593)
mvilacad Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/ui/tests/route-impact.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,14 @@ describe("route-impact", () => {
expect(pick("site/src/templates/_shared/brand-new.ts").all).toBe(true);
});

it("a CLI source under packages/ui/bin renders nothing and selects no route (#593)", () => {
for (const file of ["packages/ui/bin/ca-ui-mcp.ts", "packages/ui/bin/codeatlas-ui.ts"]) {
const s = pick(file);
expect(s.all).toBe(false);
expect(s.routes).toEqual([]);
}
});

it("selects every route for a component the site shell renders on every page", () => {
// Which components the shell renders changes with the site (#556 moved Button out of it): read it
// from the map rather than naming one.
Expand Down
1 change: 1 addition & 0 deletions scripts/route-impact.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ const NO_ROUTE_IMPACT = [
/^(\.github|\.changeset|\.agents|\.vscode|docs)\//,
/^(llms\.txt|lefthook\.yml|biome\.json|bunfig\.toml|tsconfig\.json|\.editorconfig|\.gitignore|LICENSE|NOTICE|package\.json)$/,
/^scripts\//,
/^packages\/ui\/bin\//, // CLIs (codeatlas-ui, ca-ui-mcp): Node programs no page renders or imports
/^packages\/ui\/tests\//,
/^packages\/ui\/(vite\.config\.ts|svelte\.config\.js|tsconfig\.json|size-limit\.json|CHANGELOG\.md)$/,
/\.(svelte\.test|vrt\.test|ssr\.test)\.ts$|\.test\.svelte$|__screenshots__\//,
Expand Down