Repository navigation
feat: refactor: share the Date field shell and calendar frame (jscpd: ~600 duplicated lines) - #624
Merged
Merged
Conversation
mvilacad
force-pushed
the
feat/623-refactor-share-the-date-field-shell
branch
from
October 25, 2026 21:28
789aa59 to
84489c1
Compare
mvilacad
marked this pull request as ready for review
October 25, 2026 21:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #623
Change
DateField, TimeField, DatePicker and DateRangePicker repeated the same chrome (label, bordered segment group, hidden form input, error/description line) and Calendar/RangeCalendar the same frame. Both now live in
DateFieldShell.svelteandCalendarFrame.svelte(internal, not exported);date-utils.tsgains the shared helper. Net -180 lines (120 added, 300 removed). Behaviour and markup are unchanged: no test was edited.Evidence
bun run test:browser -- src/lib/components/Date: 6 files, 46 tests passed (axe in every state, keyboard flows, pt-BR segments).Checklist
bun run validatepasses (pre-push)