Skip to content

fix: fix: test: regenerate darwin baselines of /theme/ mobile after #619 (preview CSS now server-rendered) - #639

Merged
mvilacad merged 2 commits into
mainfrom
fix/638-fix-test-regenerate-darwin-baselines-of
Oct 25, 2026
Merged

mvilacad merged 2 commits into
mainfrom
fix/638-fix-test-regenerate-darwin-baselines-of

Conversation

@mvilacad

@mvilacad mvilacad commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Closes #638

Evidence

  • Fails on clean main (c209100), bun run test:vrt: visual-mobile /theme/ dark 11009 px (4%) and light 29735 px (9%) differ; desktop and every other page pass.
  • Cause: fix: fix: theme flashes: share URL and applied visitor theme paint the default theme first #619 moved the preview's theme CSS from svelte:head (dropped by Astro island SSR) into the stage, so the server-rendered studio now carries its stage styles. Intended layout change; the baselines predate it (the land gate leaves screenshots out for a shared change).
  • Only the two mobile baselines changed. After the update /theme/ passes twice in a row (4 passed each, desktop and mobile).

@mvilacad
mvilacad marked this pull request as ready for review October 25, 2026 21:56
@mvilacad
mvilacad merged commit c0d7a9d into main Oct 25, 2026
@mvilacad
mvilacad deleted the fix/638-fix-test-regenerate-darwin-baselines-of branch October 25, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: test: regenerate darwin baselines of /theme/ mobile after #619 (preview CSS now server-rendered)

1 participant