Skip to content

fix: fix: release commit fails pre-push validate: migrations.test asserts at least one pending changeset #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvilacad merged 2 commits into from
Oct 25, 2026
Merged

fix: fix: release commit fails pre-push validate: migrations.test asserts at least one pending changeset #642

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3179e34
chore: start #641
mvilacad Oct 25, 2026
8c0b30c
fix: changeset policy test accepts an empty changeset dir (#641)
mvilacad Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/ui/tests/migrations.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,13 @@ describe("release policy (#382)", () => {
it("every pending changeset in .changeset/ passes the policy", () => {
const dir = join(ROOT, ".changeset");
const ids = new Set(entries.map((e) => e.id));
// An empty directory is valid: `bun run release` consumes every changeset, and the release commit
// must still pass the pre-push validate (#641).
const files = readdirSync(dir).filter((f) => f.endsWith(".md") && f !== "README.md");
expect(files.length).toBeGreaterThan(0);
for (const f of files)
expect(checkChangeset(readFileSync(join(dir, f), "utf8"), ids), f).toBeUndefined();
const failures = files
.map((f) => [f, checkChangeset(readFileSync(join(dir, f), "utf8"), ids)])
.filter(([, problem]) => problem !== undefined);
expect(failures).toEqual([]);
});

it("every breaking line of a released major links a migration id", () => {
Expand Down