Repository navigation
feat: support FCM fid target - #304
Merged
Merged
Conversation
Member
|
Thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appreciate all the work that went into this library.
The Firebase docs are only partially updated but the registration id
tokentarget is being deprecated in favour of thefidfirebase installation ID.I will caution that their warning is not be taken lightly:
Warning
Caution: Don't use both the Firebase Installation ID APIs and the deprecated registration token APIs for registration management at the same time.
For example, I was trying to add tests, but it seems like as soon as you succeed with a
fidtarget, the old registration ID token targets don't work anymore, at least from the same device.