Skip to content

docs: style-guide follow-ups, SDK typecheck fix, and refreshed OG image - #179

Merged
wolpert merged 3 commits into
mainfrom
docs/style-followups
Oct 8, 2026
Merged

wolpert merged 3 commits into
mainfrom
docs/style-followups

Conversation

@wolpert

@wolpert wolpert commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • SDK typecheck: test/ceremonies.test.ts imported four types from ../dist/src, which never exists. Vitest erases type imports so tests passed, but tsc --noEmit failed, which also blocked prepublishOnly. The types now come from ../src/types with the file's other type imports.
  • Site emphasis: decorative <em>, <b>, <strong>, and <i> replaced with classed <span>s. Italic h2 accents and italic glosses are gone; list labels, step numbers, group-id prefixes, marker diamonds, and the wordmark keep their layout. Dead CSS for removed <strong> uses deleted.
  • OG image: tagline rendered without the italic accent, hardcoded version removed (it said v2.1.0), and og-image.png regenerated from the SVG with headless Chrome.
  • ADR titles: rewritten as noun phrases within the heading rules (0001, 0004, 0006, 0008, 0010, 0011, 0016, 0018). File names are unchanged, so links still resolve; the index table is updated.
  • ADR 0015: the consequence about a ttl field on JwtClaims is corrected. JwtClaims has no device field, and PkAuthJwtIssuer passes Optional.empty() for deviceId.
  • SECURITY.md: supported versions now name the 2.x line. 1.x is listed as unsupported (upgrade to 2.x), following the previous latest-major-only pattern. This is a policy change worth confirming.

Test plan

  • npm run typecheck and npm test (103 tests) pass in clients/passkeys-browser
  • ./gradlew check (JDK 21) passes
  • Site rendered in headless Chrome; changed sections checked visually; HTML tag balance verified

🤖 Generated with Claude Code

wolpert and others added 3 commits October 8, 2026 06:29
- fix(sdk): ceremonies.test.ts imported types from the nonexistent
  '../dist/src'; import them from '../src/types' so `npm run typecheck`
  (and therefore `prepublishOnly`) passes.
- site: replace decorative <em>/<b>/<strong>/<i> with classed spans;
  drop italic heading accents and italic glosses; remove dead CSS.
- og-image: plain tagline (no italic accent), drop hardcoded version,
  regenerate og-image.png from the SVG.
- ADR titles: noun phrases within the heading rules (0001, 0004, 0006,
  0008, 0010, 0011, 0016, 0018); index updated, file names unchanged.
- ADR 0015: correct the deviceId consequence (JwtClaims has no ttl or
  device field; PkAuthJwtIssuer passes Optional.empty()).
- SECURITY.md: supported line is 2.x; 1.x is no longer supported.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Resolves Dependabot alert GHSA-68fv-2mgg-jv7q (high): event-loop denial
of service through indexed source-map section offsets in source-map-js
>= 1.0.0, < 1.2.2. The package is a transitive dev dependency (via
tsup/postcss, jsdom/css-tree, and @vitest/coverage-v8/magicast);
lockfile-only change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Clears the remaining moderate npm audit findings, all transitive dev
dependencies of @stryker-mutator/core:
- fast-uri 3.1.7 -> 3.1.8 (GHSA-hrr3-gc8f-f4qj, via ajv)
- qs 6.15.3 -> 6.16.0 (GHSA-x5fp-wj9c-mxmx, GHSA-4mjr-xmp4-gh2g, via
  typed-rest-client)
Lockfile-only change; npm audit reports 0 vulnerabilities.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@wolpert
wolpert enabled auto-merge (rebase) October 8, 2026 13:50
@sonarqubecloud

sonarqubecloud Bot commented Oct 8, 2026

Copy link
Copy Markdown

@wolpert
wolpert merged commit c252467 into main Oct 8, 2026
8 checks passed
@wolpert
wolpert deleted the docs/style-followups branch October 8, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant