Repository navigation
build: bump google-java-format to 1.36.1 for JDK 25 support - #182
Merged
Merged
Conversation
Spotless runs google-java-format inside the Gradle daemon JVM. On JDK 25, 1.25.2 refuses to run (it needs at least 1.30.0), so spotlessCheck and therefore check fail before any formatting is checked. 1.36.1 is the newest release compatible with Spotless 8.10.3; 1.37.0 removes JavaFormatterOptions.Style.valueOf, which Spotless 8.10.3 calls. No sources needed reformatting, and ./gradlew check passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./gradlew checkfails when Gradle runs on JDK 25. Spotless runs google-java-format inside theGradle daemon JVM, and the pinned 1.25.2 refuses to start there:
This bumps
google-java-formatingradle/libs.versions.tomlfrom 1.25.2 to 1.36.1. Spotless staysat 8.10.3.
Why not 1.37.0
1.37.0 removes
JavaFormatterOptions.Style.valueOf(String), which Spotless 8.10.3 calls, so everyfile fails with
NoSuchMethodError. 1.36.1 is the newest release that works with the currentSpotless. A future Dependabot bump to 1.37.0 will need a Spotless upgrade alongside it.
Testing
./gradlew spotlessCheckpasses on JDK 25; no sources needed reformatting../gradlew checkpasses (BUILD SUCCESSFUL).🤖 Generated with Claude Code